Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Re-ordering the menu for APIs and Queries & deleting BetaTag component as its deprecated #31552

Merged
merged 1 commit into from Mar 6, 2024

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Mar 6, 2024

Description

  • Re-ordering the menu for APIs and Queries as per design: https://zpl.io/y189pDq
  • Deleting BetaTag component as its deprecated and not being used anymore
  • Updating the type for label key under TreeDropdownOption interface to support EE changes

PR fixes following issue(s)

Fixes #31319 #32518

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

  • Manual
  • JUnit
  • Jest
  • Cypress

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

  • New Features
    • Added a "Create Module" option to the context menu for enhanced file management.
  • Refactor
    • Improved the control flow and options filtering in the context menu.
    • Updated context menu labels to support React components for enhanced flexibility.

Copy link
Contributor

coderabbitai bot commented Mar 6, 2024

Walkthrough

Walkthrough

The changes made across several files in the editor's explorer module primarily focused on refining the user interface and enhancing the functionality of context menus. Specifically, these modifications include reordering context menu items for a better user experience, updating the type of labels in dropdown options to support React nodes, and adding a new context menu item for creating modules from existing queries.

Changes

File Path Change Summary
.../Explorer/Actions/ActionEntityContextMenu.tsx Moved convertQueryToModuleOption logic within menuItems.includes check for better option filtering.
.../Explorer/ContextMenu.tsx Updated TreeDropdownOption interface to accept React.ReactNode for label property.
.../Explorer/Files/FilesContextProvider.tsx Added "Create Module" item to ActionEntityContextMenuItemsEnum.

Assessment against linked issues

Objective Addressed Explanation
Ensure the "Create module" option follows the specified order in the context menu (#31319)

By analyzing the changes made, the objectives outlined in the linked issue have been addressed. The order of the "Create module" option in the context menu now aligns with the design specifications, as it has been explicitly added and the logic around menu item inclusion has been refined to ensure correct ordering and functionality.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added Convert to module Issues related to the module creation flow using conversion Packages pod issues that belong to the packages pod Task A simple Todo skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Mar 6, 2024
@ankitakinger
Copy link
Contributor Author

/ok-to-test tags="@tag.All"

Copy link

github-actions bot commented Mar 6, 2024

Whoa, @tag.All spotted in your test suite! 🚀
While @tag.All is cool, like a catch-all net, why not try specific tags? 🏷️
Narrow down your suite with specific tags for quicker and more accurate tests! 🚀 Less waiting, more zipping through tests like a ninja!
Explore the tags documentation here

Copy link

github-actions bot commented Mar 6, 2024

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8170294250.
Workflow: Appsmith External Integration Test Workflow.
Tags: ``.

Copy link

github-actions bot commented Mar 6, 2024

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8170294250.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Widgets/ListV2/ListV2_PageNo_PageSize_spec.js

To know the list of identified flaky tests - Refer here

Copy link

github-actions bot commented Mar 6, 2024

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8170294250.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@nidhi-nair nidhi-nair merged commit 530bbb9 into release Mar 6, 2024
20 checks passed
@nidhi-nair nidhi-nair deleted the chore/beta-tag-for-modules branch March 6, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Convert to module Issues related to the module creation flow using conversion Packages pod issues that belong to the packages pod skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
None yet
3 participants