Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant evalTreeWithChanges calls during plugin page load call #32459

Merged
merged 1 commit into from Apr 8, 2024

Conversation

vsvamsi1
Copy link
Contributor

@vsvamsi1 vsvamsi1 commented Apr 5, 2024

Description

Removed redundant evalTreeWithChanges calls made during plugin on load execution. We have noticed a 30% reduction in both main thread and web worker scripting.

Fixes #32475

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Important

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8578827174
Commit: 0446a81d087ad975f12cd8e3a83c10380b5eb52d
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

Summary by CodeRabbit

Summary by CodeRabbit

  • Refactor
    • Streamlined the execution logic for page load actions to improve performance and code clarity.

@vsvamsi1 vsvamsi1 self-assigned this Apr 5, 2024
@vsvamsi1 vsvamsi1 removed the request for review from ayushpahwa April 5, 2024 11:28
Copy link
Contributor

coderabbitai bot commented Apr 5, 2024

Walkthrough

Walkthrough

This update focuses on optimizing the execution flow within a particular module by eliminating unnecessary redundancy. Specifically, it streamlines the process of updating action data during page load actions, enhancing code efficiency and readability by removing superfluous calls to updateActionData.

Changes

File Path Change Summary
.../ActionExecution/PluginActionSaga.ts Streamlined updateActionData calls in executePageLoadAction function to improve code clarity and eliminate redundancy.

Assessment against linked issues

Objective Addressed Explanation
Remove redundant evalTreeWithChanges call in plugin load flow (#32475)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vsvamsi1 vsvamsi1 marked this pull request as draft April 5, 2024 11:29
@vsvamsi1 vsvamsi1 added the ok-to-test Required label for CI label Apr 5, 2024
@vsvamsi1
Copy link
Contributor Author

vsvamsi1 commented Apr 6, 2024

/build-deploy-preview skip-tests=true

Copy link

github-actions bot commented Apr 6, 2024

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8578405500.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 32459.
recreate: .

Copy link

github-actions bot commented Apr 6, 2024

Deploy-Preview-URL: https://ce-32459.dp.appsmith.com

@github-actions github-actions bot added Performance Issues related to performance Performance Pod All things related to Appsmith performance labels Apr 6, 2024
@vsvamsi1 vsvamsi1 changed the title test removing redundant operations chore: remove redundant evalTreeWithChanges calls during plugin page load call Apr 6, 2024
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Apr 6, 2024
@github-actions github-actions bot added the Task A simple Todo label Apr 6, 2024
@vsvamsi1 vsvamsi1 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Apr 6, 2024
@vsvamsi1 vsvamsi1 marked this pull request as ready for review April 6, 2024 04:53
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsvamsi1 vsvamsi1 merged commit dcd97da into release Apr 8, 2024
85 checks passed
@vsvamsi1 vsvamsi1 deleted the workingRemoveHandleAction branch April 8, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI Performance Pod All things related to Appsmith performance Performance Issues related to performance skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant evalTreeWithChanges call in plugin load flow
2 participants