fix:button icon settings

[KelvinOm]

Description

The position of the icon no longer changes when the icon is changed

Fixes #32032

Automation

/ok-to-test tags="@tag.Anvil"

🔍 Cypress test results

Important

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8599346122
Commit: 7d63e83b83460cf1625b5656191afdcd0f5af7d7
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

[coderabbitai]

Walkthrough

Walkthrough

The recent changes introduced feature flag updates and a modification in the widget configuration system. Specifically, new feature flags were added to enhance functionality, and an update hook within a widget's style configuration was removed to streamline or possibly fix an issue related to property updates.

Changes

File Path	Change Summary
.../src/ce/sagas/userSagas.tsx	Added release_anvil_enabled and ab_wds_enabled feature flags
.../wds/WDSButtonWidget/config/.../styleConfig.ts	Removed updateHook function from propertyPaneStyleConfig

Assessment against linked issues

Objective	Addressed	Explanation
Retain icon alignment settings when icon is changed on the widget (#32032)	❌	The changes do not directly address or relate to the icon alignment settings issue.

Possibly related issues

• [Bug]: Button group widget's buttons have the most confusing naming convention on the platform #15987: The removal of the updateHook might indirectly affect how button group widget properties are updated, potentially improving usability as per the objectives. However, without specific details on how updateHook impacted the naming convention, this is speculative.
• [Bug]: Alignment of checkboxes for options not consistent #24111: The changes do not directly impact the alignment issues within the MultiSelect widget, as they pertain to a different part of the codebase.
• Fix modal widget issues  #30788: There is no direct connection between the modal widget issues and the recent changes, as the modifications focus on feature flags and widget style configuration.
• [Bug]: Widget list getting cut down in the bottom #30179: The adjustments made do not address the visibility or scrollability of the widget list, as the changes are unrelated to UI layout or widget list management.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.