feat: update copy from widgets to UI elements #32514

jacquesikot · 2024-04-09T05:29:17Z

Description

Tip

With the addition of building blocks to the explorer items, we need to change the widget name to something that better encapsulates the contents of the canvas explorer. All instances of "widgets" in the canvas explorer have been changed to "UI elements"

Fixes #32331

Automation

/ok-to-test tags="@tag.Widget, @tag.MainContainer, @tag.Visual"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8777493414
Commit: 97f5cdb
Cypress dashboard url: Click here!

Summary by CodeRabbit

New Features
- Added new constants and updated text descriptions for UI elements in the editor pane.
- Enhanced the multi-select property pane with clearer text.
Refactor
- Changed terminology from "widgets" to "UI elements" across various UI components.
Style
- Updated messages and placeholder texts to improve user interface clarity and consistency.

…o release

…o feat/update-widget-to-ui-element

coderabbitai · 2024-04-09T05:29:26Z

Walkthrough

The changes in this pull request focus on updating terminology and enhancing UI consistency by transitioning from "widgets" to "UI elements" and refining multi-selection labels. These modifications aim to improve clarity and uniformity within the editor's user interface, aligning with user feedback and evolving needs.

Changes

File Path	Change Summary
`app/client/src/ce/constants/messages.ts`	Updated text descriptions and button labels from "widgets" to "UI elements". Added `WIDGET_MULTI_SELECT` constant.
`app/client/src/pages/Editor/MultiSelectPropertyPane/index.tsx`	Updated displayed text from "Multi" to "Multiple selected".
`app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx`	Updated placeholder text from "Search widgets" to "Search UI elements".

Assessment against linked issues

Objective	Addressed	Explanation
Improve naming convention for copied widgets and queries to enhance UI aesthetics and conformity to standard naming practices. (#32331)	❌	The PR does not address the specific issue of naming convention for copied widgets and queries.
Address the issue of appended "copy" leading to an unattractive UI. (#32331)	❌	The PR does not address the removal of "copy" appending to widgets and queries.
Propose sequential naming for copied widgets/queries. (#32331)	❌	Sequential naming for copied widgets/queries is not implemented in this PR.
Ensure new naming convention aligns with standard practices. (#32331)	❌	The PR does not introduce a new naming convention to align with standard practices.
Update copy in widget explorer from "Widgets" to "UI elements". (#32331)	✅
Remove highlighting of newly imported building block widgets on the canvas. (#32331)	❌	The provided summary does not mention changes related to the highlighting of building blocks.
Update copy from "Multi" to "Multiple selected". (#32331)	✅

Possibly related issues

[Feature]: Better naming convention for copied properties #14322: The changes in terminology from "widgets" to "UI elements" could indirectly impact the naming convention and UI aesthetics discussed in this issue, although the direct objectives are not addressed.
[Task] Rename UI module instance #30782: While this issue focuses on renaming a UI module instance, the overall theme of improving clarity and consistency through renaming could be related. However, the PR does not directly address renaming a specific UI module instance.
[Bug]: Alignment of checkboxes for options not consistent #24111: This issue is focused on alignment within a specific widget and is not addressed by the changes in terminology or the multi-selection label update in the PR.

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between cb7a17f and 97f5cdb.

Files selected for processing (1)

app/client/src/ce/constants/messages.ts (3 hunks)

Additional comments not posted (3)

app/client/src/ce/constants/messages.ts (3)

1538-1538: Looks good! This constant correctly returns a static string.

2317-2323: This object is well-structured and correctly encapsulates strings within functions for potential localization.

2458-2458: Correctly returns a static string for use in UI elements. Well done!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sbalaji1192

change looks good. Make sure to run all the cypress cases once.

jacquesikot · 2024-04-09T05:34:40Z

/build-deploy-preview skip-tests=true

github-actions · 2024-04-09T05:35:00Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8610855095.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 32514.
recreate: .

github-actions · 2024-04-09T05:49:03Z

Deploy-Preview-URL: https://ce-32514.dp.appsmith.com

app/client/src/pages/Editor/MultiSelectPropertyPane/index.tsx

app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx

github-actions · 2024-04-17T16:35:42Z

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

…o feat/update-widget-to-ui-element

## Description New text needed to be updated caused by #32514 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results  > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR.  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Tests** - Enhanced API pane tests to use centralized text management for improved consistency and maintainability. - Updated test configurations to reflect the renamed test specification file. - Improved import statements for better code organization. - Modified text content within `AssertElementVisibility` calls for clarity. - Added import statements for `createMessage` and `EDITOR_PANE_TEXTS`. - Updated import path for `createMessage`. - Modified text content within `AssertElementVisibility` calls to use `createMessage` with `EDITOR_PANE_TEXTS`.

jacquesikot added 15 commits January 10, 2024 10:47

remove testid from ForkTemplate modal

3d10db4

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

be509fd

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

5f53f7d

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

4e84de9

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

d34ab5d

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

6c76fc0

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

fbf2da8

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

1435ce3

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

4b77394

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

b348574

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

bc4cafb

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

6e9baea

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

1dd0e9a

…o release

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

4dc0c63

…o feat/update-widget-to-ui-element

update all copies

19eb1dd

jacquesikot requested a review from sbalaji1192 April 9, 2024 05:29

jacquesikot self-assigned this Apr 9, 2024

github-actions bot added Task A simple Todo Templates Templates Product Issues related to Templates labels Apr 9, 2024

jacquesikot requested a review from rahulbarwal April 9, 2024 05:29

github-actions bot added the Enhancement New feature or request label Apr 9, 2024

sbalaji1192 reviewed Apr 9, 2024

View reviewed changes

sbalaji1192 previously approved these changes Apr 9, 2024

View reviewed changes

jacquesikot added the ok-to-test Required label for CI label Apr 9, 2024

mohanarpit reviewed Apr 9, 2024

View reviewed changes

app/client/src/pages/Editor/MultiSelectPropertyPane/index.tsx Outdated Show resolved Hide resolved

rahulbarwal requested changes Apr 9, 2024

View reviewed changes

app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx Outdated Show resolved Hide resolved

move strings to messages

cb7a17f

jacquesikot dismissed sbalaji1192’s stale review via cb7a17f April 9, 2024 09:34

jacquesikot requested a review from rahulbarwal April 9, 2024 09:34

rahulbarwal approved these changes Apr 9, 2024

View reviewed changes

rahulbarwal added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Apr 10, 2024

github-actions bot added the Stale label Apr 17, 2024

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

017e65c

…o feat/update-widget-to-ui-element

jacquesikot added ok-to-test Required label for CI and removed ok-to-test Required label for CI Stale labels Apr 18, 2024

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

97f5cdb

…o feat/update-widget-to-ui-element

jacquesikot added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Apr 22, 2024

jacquesikot merged commit ef279d1 into release Apr 22, 2024
46 checks passed

jacquesikot deleted the feat/update-widget-to-ui-element branch April 22, 2024 04:35

ApekshaBhosale mentioned this pull request Apr 22, 2024

fix: API_Pane_spec - Fixed new messages #32848

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update copy from widgets to UI elements #32514

feat: update copy from widgets to UI elements #32514

jacquesikot commented Apr 9, 2024 •

edited

Loading

coderabbitai bot commented Apr 9, 2024 •

edited

Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

sbalaji1192 left a comment

jacquesikot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 17, 2024

feat: update copy from widgets to UI elements #32514

feat: update copy from widgets to UI elements #32514

Conversation

jacquesikot commented Apr 9, 2024 • edited Loading

Description

Automation

🔍 Cypress test results

Summary by CodeRabbit

coderabbitai bot commented Apr 9, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

sbalaji1192 left a comment

Choose a reason for hiding this comment

jacquesikot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 17, 2024

jacquesikot commented Apr 9, 2024 •

edited

Loading

coderabbitai bot commented Apr 9, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)