fix: Api Pane IA #32603
fix: Api Pane IA #32603
Conversation
WalkthroughWalkthroughThe updates involve a restructuring of the Changes
Assessment against linked issues
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional comments not posted (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
Bug
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -0,0 +1,126 @@ | |||
| import type { PropsWithChildren } from "react"; | |||
There was a problem hiding this comment.
Consider removing the unused import PropsWithChildren as it is not utilized in the component.
- import type { PropsWithChildren } from "react";Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| import type { PropsWithChildren } from "react"; |
| const BaseText = styled(BlueprintText)<TextStyleProps>``; | ||
| const ResponseMetaInfo = styled.div` | ||
| display: flex; | ||
| ${BaseText} { | ||
| color: var(--ads-v2-color-fg); | ||
| margin-left: ${(props) => props.theme.spaces[9]}px; | ||
| } | ||
|
|
||
| & [type="p3"] { | ||
| color: var(--ads-v2-color-fg-muted); | ||
| } | ||
|
|
||
| & [type="h5"] { | ||
| color: var(--ads-v2-color-fg); | ||
| } | ||
| `; |
There was a problem hiding this comment.
Ensure consistent use of theme variables for margins and colors to maintain themability and ease of future style changes.
const BaseText = styled(BlueprintText)<TextStyleProps>``;
const ResponseMetaInfo = styled.div`
display: flex;
${BaseText} {
- color: var(--ads-v2-color-fg);
+ color: ${(props) => props.theme.colors.foreground};
- margin-left: ${(props) => props.theme.spaces[9]}px;
+ margin-left: ${(props) => props.theme.spaces[3]}px; // Adjusted for consistency
}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const BaseText = styled(BlueprintText)<TextStyleProps>``; | |
| const ResponseMetaInfo = styled.div` | |
| display: flex; | |
| ${BaseText} { | |
| color: var(--ads-v2-color-fg); | |
| margin-left: ${(props) => props.theme.spaces[9]}px; | |
| } | |
| & [type="p3"] { | |
| color: var(--ads-v2-color-fg-muted); | |
| } | |
| & [type="h5"] { | |
| color: var(--ads-v2-color-fg); | |
| } | |
| `; | |
| const BaseText = styled(BlueprintText)<TextStyleProps>``; | |
| const ResponseMetaInfo = styled.div` | |
| display: flex; | |
| ${BaseText} { | |
| color: ${(props) => props.theme.colors.foreground}; | |
| margin-left: ${(props) => props.theme.spaces[3]}px; // Adjusted for consistency | |
| } | |
| & [type="p3"] { | |
| color: var(--ads-v2-color-fg-muted); | |
| } | |
| & [type="h5"] { | |
| color: var(--ads-v2-color-fg); | |
| } | |
| `; |
Description
Fixes the IA in API Response Pane by moving the meta information about the API call inside the response tab
Fixes #32602
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8645605363
Commit: 25936d8
Cypress dashboard url: Click here!