feat: remote js execution code split #32853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushpahwa
changed the title
github-actions
bot
added
Task
ayushpahwa
added
ok-to-test
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
app/client/src/components/editorComponents/JSResponseView.test.tsx
Outdated
Show resolved
Hide resolved
ankitakinger
reviewed
May 2, 2024
| @@ -0,0 +1,3 @@ | |||
| export default function JSRemoteExecutionView({}: any) { | |||
There was a problem hiding this comment.
I think you have missed the CE version of this file?
There was a problem hiding this comment.
Updated, please check
ayushpahwa
added
ok-to-test
rishabhrathod01
approved these changes
May 3, 2024
ayushpahwa
added
ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a code split PR for EE feature which allows remote JS execution for JS functions. The changes majorly relate to workflows code. Changelog:
JsPaneSagasFixes #32318
Fixes #32320
Fixes #32321
Automation
/ok-to-test tags="@tag.Sanity, @tag.JS"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8946098385
Commit: ff7aeec
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?