Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check page permission to show widget add panel #32913

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Apr 24, 2024

Description

When the user does not have permission to edit a page, they should not be shown the widget pane with widgets

Fixes #32708

Automation

/ok-to-test tags="@tag.IDE, @tag.AccessControl"

馃攳 Cypress test results

Tip

馃煝 馃煝 馃煝 All cypress tests have passed! 馃帀 馃帀 馃帀
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8814962106
Commit: 113a147
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • [ x ] No

Summary by CodeRabbit

  • New Features
    • Enhanced security by implementing permission checks before rendering widgets in the editor UI.

@hetunandu hetunandu added the ok-to-test Required label for CI label Apr 24, 2024
Copy link
Contributor

coderabbitai bot commented Apr 24, 2024

Walkthrough

Walkthrough

The update introduces a permission check mechanism for managing pages within the UI segment of the editor pane. This ensures that widgets are only rendered if the user has the appropriate permissions, enhancing security and user experience by preventing unauthorized access to page management functionalities.

Changes

File Path Change Summary
app/.../EditorPane/UI/index.tsx Added logic to verify page management permissions before rendering widgets.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 4b9dddc and 113a147.
Files selected for processing (1)
  • app/client/src/pages/Editor/IDE/EditorPane/UI/index.tsx (1 hunks)
Additional comments not posted (3)
app/client/src/pages/Editor/IDE/EditorPane/UI/index.tsx (3)

16-20: Imports and Redux selector setup for permissions look correctly implemented.


26-32: Permission check logic using feature flags and page permissions is correctly implemented.


34-36: Conditional rendering based on page management permissions is correctly implemented.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Production labels Apr 24, 2024
@hetunandu hetunandu added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Apr 24, 2024
@hetunandu hetunandu merged commit 17cb7bc into release Apr 25, 2024
50 of 52 checks passed
@hetunandu hetunandu deleted the fix/widget-add-pane-permissions branch April 25, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE ok-to-test Required label for CI Production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Widgets section is shown for user r=even if user doesn't have permission
2 participants