Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Introduce defaultId as internal concept #32951

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

nidhi-nair
Copy link
Contributor

@nidhi-nair nidhi-nair commented Apr 25, 2024

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

馃攳 Cypress test results

Caution

馃敶 馃敶 馃敶 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8828953698
Commit: 2d51369
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
To know the list of identified flaky tests - Refer here

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@nidhi-nair nidhi-nair added the ok-to-test Required label for CI label Apr 25, 2024
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Apr 25, 2024
@nidhi-nair nidhi-nair changed the base branch from release to chore/rm-dr April 29, 2024 04:15
@nidhi-nair nidhi-nair marked this pull request as ready for review April 29, 2024 04:16
@nidhi-nair nidhi-nair merged commit 321a82a into chore/rm-dr Apr 29, 2024
84 of 88 checks passed
@nidhi-nair nidhi-nair deleted the chore/add-defaultid-branch-aware branch April 29, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant