Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datasources headings fixed for IA redesign panel #33003

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

NilanshBansal
Copy link
Contributor

@NilanshBansal NilanshBansal commented Apr 29, 2024

Description

This PR fixes the inconsistency in the IA redesign side panel for data sources.

Fixes #28898

Automation

/ok-to-test tags="@tag.IDE,@tag.Datasource,@tag.GenerateCRUD"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8873315346
Commit: f86f390
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Updated plugin categorization to include specific types: "SaaS integrations" and "AI integrations" for improved user experience in selecting plugins.

Copy link
Contributor

coderabbitai bot commented Apr 29, 2024

Walkthrough

Walkthrough

The recent update involves renaming the PluginCategory.Integrations enum value to more specific categories: PluginCategory.SaaS integrations and PluginCategory.AI integrations. This change aims to improve clarity and consistency in the categorization of plugins, specifically addressing inconsistencies in headings across different user interface panels.

Changes

File Path Change Summary
.../src/ce/selectors/entitiesSelector.ts Renamed PluginCategory.Integrations to PluginCategory.SAAS and PluginCategory.AI. Updated related logic in getDatasourcesGroupedByPluginCategory.

Assessment against linked issues

Objective Addressed Explanation
Consistency in headings for SaaS integrations across different panels (#28898)
Update enum values to reflect specific integration types rather than a general "Integrations" (#28898)
Ensure that the data source categorization aligns with new enum values in the IA redesign (#28898)

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between e71876f and f86f390.
Files selected for processing (1)
  • app/client/src/ce/selectors/entitiesSelector.ts (2 hunks)
Additional comments not posted (2)
app/client/src/ce/selectors/entitiesSelector.ts (2)

87-88: Updated PluginCategory enum to include "SaaS integrations" and "AI integrations". This change aligns with the PR's objective to clarify and separate different types of integrations, enhancing UI consistency and clarity.


116-120: Updated getDatasourcesGroupedByPluginCategory selector to categorize datasources using the new PluginCategory values. This ensures that datasources are grouped under the correct headings in the UI, which is crucial for the IA redesign side panel.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NilanshBansal NilanshBansal self-assigned this Apr 29, 2024
@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Integrations Pod Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Low effort Takes 1-2 days Needs Triaging Needs attention from maintainers to triage Production labels Apr 29, 2024
@NilanshBansal NilanshBansal added the ok-to-test Required label for CI label Apr 29, 2024
@NilanshBansal NilanshBansal merged commit 9ba7036 into release Apr 29, 2024
46 of 47 checks passed
@NilanshBansal NilanshBansal deleted the fix/issue-28898/ds-heading branch April 29, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Integrations Pod Issues related to a specific integration Low effort Takes 1-2 days Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The heading is inconsistent, on DS page and on the IA redesign panel
2 participants