fix: Updating the action check to initialize the super user sagas

[ankitakinger]

Description

Updating the action calls for sagas to trigger the Admin setting APIs. This was required after the consolidated API changes came in, as the API takes long time to load and FETCH_USER_SUCCESS call happens before FETCH_FEATURE_FLAGS_SUCCESS call. We need both of the actions to be successful before adding the saga. Hence updating it to the action END_CONSOLIDATED_PAGE_LOAD now.

Fixes #33034

Automation

/ok-to-test tags="@tag.Settings"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8877126026
Commit: a5f7a06
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Enhanced the initialization process for super users to conditionally trigger actions based on specific feature availability.

• Refactor

  • Updated logic in the Super User initialization to improve how feature flags and user details are checked and utilized.

[coderabbitai]

Walkthrough

Walkthrough

The update to SuperUserSagas.tsx involves enhancing the InitSuperUserSaga function to better utilize Redux selectors for fetching current user details and feature flags. It checks for specific feature availability and conditionally triggers actions based on these checks, aiming to streamline access and functionality related to super user capabilities.

Changes

File	Change Summary
app/client/src/ee/sagas/SuperUserSagas.tsx	Updated InitSuperUserSaga to use selectors for user and feature flags, added conditional action triggers. Changed action type in SuperUserSagas.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure that non-super admin users with custom roles can access Groups & Roles pages (Issue #33034)	❓	The changes include better feature flag checks and user role evaluations, which could potentially address the issue. However, without specific details on how the user permissions are verified against these feature flags, it's unclear if the exact issue is resolved.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6dfc093 and a5f7a06.

Files selected for processing (1)

• app/client/src/ee/sagas/SuperUserSagas.tsx (2 hunks)

Additional comments not posted (3)

app/client/src/ee/sagas/SuperUserSagas.tsx (3)

12-17: Ensure all new imports are utilized appropriately in the saga.

---

19-24: Updated logic in InitSuperUserSaga to use selectors and conditionally trigger actions based on feature flags and user details.

---

44-44: Updated SuperUserSagas to trigger on END_CONSOLIDATED_PAGE_LOAD, aligning with PR objectives to ensure necessary data is loaded before saga execution.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[brayn003]

lgtm