fix: Drag drop Building blocks prompt fixes #33093
Conversation
rahulbarwal
added
Bug
rahulbarwal
added
the
Building blocks
WalkthroughThe changes aim to enhance drag-and-drop functionality for building blocks, update UI rendering conditions, and introduce new components to improve the user experience. Text content settings in components are also adjusted based on specific conditions in the IDE environment. Changes
Assessment against linked issues
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
rahulbarwal
changed the title
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8906430998. |
|
Deploy-Preview-URL: https://ce-33093.dp.appsmith.com |
…eparate component.
…o fix/33085/dragdropprompt-enabled-at-weird-times
…eparate component.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -41,11 +42,13 @@ const BuildingBlockExplorerDropTarget = () => { | |||
|
|
|||
| <TextContainer> | |||
| <Text kind="heading-s" style={{ marginBottom: "4px" }}> | |||
| Drag & drop a building block | |||
| {createMessage(EMPTY_CANVAS.DRAG_DROP_BUILDING_BLOCK_HINT.TITLE)} | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The message key EMPTY_CANVAS.DRAG_DROP_BUILDING_BLOCK_HINT.TITLE used in the BuildingBlockExplorerDropTarget component does not appear to be defined in the messages.ts file located at app/client/src/layoutSystems/anvil/common/messages.ts. This could potentially lead to runtime errors if the key is indeed not defined anywhere in the codebase. It is recommended to check other messages.ts files or confirm the correct location and definition of this message key.
app/client/src/layoutSystems/anvil/common/messages.ts- Key not found
Analysis chain
Ensure the message key used here is correctly defined in the constants.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the message key `EMPTY_CANVAS.DRAG_DROP_BUILDING_BLOCK_HINT.TITLE` is defined in the messages constants file.
# Search for the message key definition in the constants file.
rg --type ts 'DRAG_DROP_BUILDING_BLOCK_HINT.TITLE' src/constants/messages.ts
Length of output: 142
Script:
#!/bin/bash
# Description: Search for the file `messages.ts` in the entire repository to confirm its existence and location.
# Use fd to find the file named messages.ts
fd messages.ts
Length of output: 566
Script:
#!/bin/bash
# Description: Verify that the message key `EMPTY_CANVAS.DRAG_DROP_BUILDING_BLOCK_HINT.TITLE` is defined in the identified messages constants file.
# Search for the message key definition in the identified constants file.
rg --type ts 'DRAG_DROP_BUILDING_BLOCK_HINT.TITLE' app/client/src/layoutSystems/anvil/common/messages.ts
Length of output: 104
app/client/src/layoutSystems/common/dropTarget/buildingBlockExplorerDropTarget/index.tsx
Outdated
Show resolved
Hide resolved
app/client/src/layoutSystems/common/dropTarget/OnBoarding/OnBoarding.test.tsx
Outdated
Show resolved
Hide resolved
…nboarding component when drag and drop is enabled.
…ate constant file.
Nikhil-Nandagopal
added
Accelerators Product
github-actions
bot
added
QA
Description
This PR fixes 2 issues:
UIwidget is selected.Fixes #33085
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Sanity, @tag.Templates"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8909118563
Commit: 6603b5c
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?