Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove existing widget selection implementation #33129

Merged
merged 11 commits into from
May 6, 2024

Conversation

riodeuno
Copy link
Contributor

@riodeuno riodeuno commented May 2, 2024

Description

With the new widget selection UX. This existing implementation is no longer necessary.
This PR removes it

Fixes: #33131

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8960841989
Commit: 4f9c6d5
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ServerSide/QueryPane/DSDocs_Spec.ts
To know the list of identified flaky tests - Refer here

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

## Description
A selector that provides the state of the widget name component to show.
- "focus" -> Focused state
- "select" -> Selected state
- "none" -> Hidden

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
@riodeuno riodeuno self-assigned this May 2, 2024
@riodeuno riodeuno added Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil labels May 2, 2024
@github-actions github-actions bot added Bug Something isn't working Task A simple Todo labels May 2, 2024
…o fix/remove-existing-widget-selection-implementation
@riodeuno riodeuno marked this pull request as ready for review May 5, 2024 20:08
Copy link
Contributor

coderabbitai bot commented May 5, 2024

Walkthrough

This set of changes primarily focuses on enhancing the user interface and simplifying the codebase for widget interactions within a layout system. The modifications include adding style properties to detached widgets, refining conditional handling in the editor wrapper, and streamlining widget data selectors by removing redundant functions and integrating their logic directly into the selectors.

Changes

File Path Change Summary
.../anvil/common/hooks/detachedWidgetHooks.ts Added borderRadius style setting in useAddBordersToDetachedWidgets function.
.../anvil/editor/AnvilEditorWrapper.tsx Introduced conditional block for handling layoutId.
.../common/selectors.ts Removed getWidgetNameState function; updated getSelectedWidgetNameData and getFocusedWidgetNameData selectors to incorporate direct logic.

Assessment against linked issues

Objective Addressed Explanation
Remove existing anvil widget selection UX implementation (#33131) The changes do not explicitly mention the removal of the old widget selection UX, focusing instead on code restructuring and style adjustments.

The changes made in this pull request seem to focus on improving the code structure and user interface elements but do not directly address the removal of the existing widget selection UX as described in the linked issue. Further clarification or additional changes may be required to fully accomplish the outlined objectives.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@riodeuno riodeuno added the ok-to-test Required label for CI label May 5, 2024
@marks0351
Copy link
Contributor

👍🏽

@riodeuno riodeuno merged commit e54020b into release May 6, 2024
83 of 85 checks passed
@riodeuno riodeuno deleted the fix/remove-existing-widget-selection-implementation branch May 6, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil Bug Something isn't working ok-to-test Required label for CI Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove existing anvil widget selection UX implementation
2 participants