-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove existing widget selection implementation #33129
fix: remove existing widget selection implementation #33129
Conversation
…o feat/anvil-widget-name-component
## Description A selector that provides the state of the widget name component to show. - "focus" -> Focused state - "select" -> Selected state - "none" -> Hidden ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No
…o feat/anvil-widget-name-component
…o feat/anvil-widget-name-component
…o fix/remove-existing-widget-selection-implementation
WalkthroughThis set of changes primarily focuses on enhancing the user interface and simplifying the codebase for widget interactions within a layout system. The modifications include adding style properties to detached widgets, refining conditional handling in the editor wrapper, and streamlining widget data selectors by removing redundant functions and integrating their logic directly into the selectors. Changes
Assessment against linked issues
The changes made in this pull request seem to focus on improving the code structure and user interface elements but do not directly address the removal of the existing widget selection UX as described in the linked issue. Further clarification or additional changes may be required to fully accomplish the outlined objectives. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
👍🏽 |
Description
With the new widget selection UX. This existing implementation is no longer necessary.
This PR removes it
Fixes: #33131
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Caution
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8960841989
Commit: 4f9c6d5
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
Communication
Should the DevRel and Marketing teams inform users about this change?