Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: authenticationType field saved to database #33196

Merged
merged 2 commits into from
May 6, 2024
Merged

fix: authenticationType field saved to database #33196

merged 2 commits into from
May 6, 2024

Conversation

NilanshBansal
Copy link
Contributor

@NilanshBansal NilanshBansal commented May 6, 2024 •
edited by github-actions bot
Loading

Description

With the introduction of FromRequest for the create datasource API in this PR, we have restricted the fields that will be accepted from the client in the request body. Due to this the authenticationType field was not getting accepted from the client in the create datasource API, which lead to the failure of airtable queries.

This PR allows the acceptance of authenticationType field from the client.
Discussions here.

Fixes #33184

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8966382606
Commit: a292aa0
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ServerSide/QueryPane/DSDocs_Spec.ts
To know the list of identified flaky tests - Refer here

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@NilanshBansal NilanshBansal self-assigned this May 6, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 6, 2024 •
edited
Loading

Walkthrough

Walkthrough

This update introduces a modification in the AuthenticationDTO.java file, where an import statement for FromRequest is added, and the @JsonView annotation is updated to include both Views.Public and FromRequest classes. This change aims to enhance the data view management in the authentication process.

Changes

File Path Changes
.../models/AuthenticationDTO.java Added import for FromRequest and updated @JsonView annotation to include Views.Public and FromRequest.

Assessment against linked issues

Objective Addressed Explanation
#33184: Resolve 'missing template name for datasource' error in Airtable queries ❌ The changes in AuthenticationDTO.java do not directly address the issue related to Airtable queries failing due to a 'missing template name for datasource'. The modifications seem unrelated to the datasource or template handling mechanisms that would typically be involved in such an issue.
Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a490128 and a292aa0.
Files selected for processing (1)
  • app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/AuthenticationDTO.java (2 hunks)
Files not reviewed due to errors (1)
  • app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/AuthenticationDTO.java (no review received)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Airtable Issues for Airtable Query & JS Pod Issues related to the query & JS Pod Bug Something isn't working Critical This issue needs immediate attention. Drop everything else Datasources Issues related to configuring datasource on appsmith High This issue blocks a user from building or impacts a lot of users Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Production Release Blocker This issue must be resolved before the release labels May 6, 2024
@NilanshBansal NilanshBansal added the ok-to-test Required label for CI label May 6, 2024
@NilanshBansal
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8967276459.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33196.
recreate: .

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Deploy-Preview-URL: https://ce-33196.dp.appsmith.com

@NilanshBansal NilanshBansal added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label May 6, 2024
@sharat87 sharat87 merged commit a5edfb0 into release May 6, 2024
46 of 50 checks passed
@sharat87 sharat87 deleted the fix/issue-33184/authenticationType-db-save branch May 6, 2024 11:00
NilanshBansal added a commit that referenced this pull request May 6, 2024
@NilanshBansal
fix: authenticationType field saved to database (#33196)
a054e8c 
## Description
With the introduction of FromRequest for the create datasource API in
[this](#33039) PR, we have
restricted the fields that will be accepted from the client in the
request body. Due to this the `authenticationType` field was not getting
accepted from the client in the create datasource API, which lead to the
failure of airtable queries.

This PR allows the acceptance of `authenticationType` field from the
client.
Discussions
[here](https://theappsmith.slack.com/archives/CTHN8GX5Y/p1714974437746959).

Fixes #33184

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8966382606>
> Commit: a292aa0
> Cypress dashboard: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8966382606&attempt=3&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank"> Click here!</a>
> The following are new failures, please fix them before merging the PR:
<ol>
> <li>cypress/e2e/Regression/ServerSide/QueryPane/DSDocs_Spec.ts </ol>
> To know the list of identified flaky tests - <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">Refer here</a>

<!-- end of auto-generated comment: Cypress test results  -->

## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No

(cherry picked from commit a5edfb0)
pedro-santos-rodrigues pushed a commit that referenced this pull request Jun 20, 2024
@NilanshBansal
fix: authenticationType field saved to database (#33196)
328be1f 
## Description
With the introduction of FromRequest for the create datasource API in
[this](#33039) PR, we have
restricted the fields that will be accepted from the client in the
request body. Due to this the `authenticationType` field was not getting
accepted from the client in the create datasource API, which lead to the
failure of airtable queries.

This PR allows the acceptance of `authenticationType` field from the
client.
Discussions
[here](https://theappsmith.slack.com/archives/CTHN8GX5Y/p1714974437746959).

Fixes #33184

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8966382606>
> Commit: a292aa0
> Cypress dashboard: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8966382606&attempt=3&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank"> Click here!</a>
> The following are new failures, please fix them before merging the PR:
<ol>
> <li>cypress/e2e/Regression/ServerSide/QueryPane/DSDocs_Spec.ts </ol>
> To know the list of identified flaky tests - <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">Refer here</a>

<!-- end of auto-generated comment: Cypress test results  -->

## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No

(cherry picked from commit a5edfb0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondermanish sondermanish sondermanish approved these changes

@nidhi-nair nidhi-nair Awaiting requested review from nidhi-nair nidhi-nair is a code owner

@sharat87 sharat87 Awaiting requested review from sharat87

Assignees

@NilanshBansal NilanshBansal

Labels
Airtable Issues for Airtable Bug Something isn't working Critical This issue needs immediate attention. Drop everything else Datasources Issues related to configuring datasource on appsmith High This issue blocks a user from building or impacts a lot of users Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production Query & JS Pod Issues related to the query & JS Pod Release Blocker This issue must be resolved before the release Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Airtable queries are failing with the error 'Missing template name for datasource'
3 participants
@NilanshBansal @sondermanish @sharat87