Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable main js rename from entity pane #33202

Merged
merged 6 commits into from
May 6, 2024
Merged

fix: disable main js rename from entity pane #33202

merged 6 commits into from
May 6, 2024

Conversation

ayushpahwa
Copy link
Contributor

@ayushpahwa ayushpahwa commented May 6, 2024 •
edited by github-actions bot
Loading

Description

Updated the condition to prevent main JS function rename from entity list

Fixes #32275

Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8967754921
Commit: 9c3f852
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 6, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent updates focus on refining the editing capabilities concerning JavaScript (JS) objects within the client application. These modifications ensure that renaming main JS collections is restricted to maintain consistency and prevent unintended changes. Additionally, a new test case has been included to verify that only non-main JS objects can be edited.

Changes

File Path Change Summary
.../JSActionEntity.tsx Updated canEditEntityName to restrict renaming for main JS collections.
.../JSRender.test.tsx Added tests to verify the conditional editability of JS objects based on their type (main or normal).
.../Entity/index.tsx Added a conditional class editable based on canEditEntityName in the Entity component.

Assessment against linked issues

Objective Addressed Explanation
[Task - Client]: Renaming of JS objects isn't happening properly from all the places. (#32275) ✅

The changes directly address the issue of improper renaming capabilities from all places by implementing conditional logic that prevents renaming of main JS collections, aligning with the task requirements in issue #32275.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 80bb9aa and e51840e.
Files selected for processing (1)
  • app/client/src/pages/Editor/Explorer/Entity/index.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/client/src/pages/Editor/Explorer/Entity/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Task A simple Todo Workflows Workflows Pod For all issues related to the Workflows feature labels May 6, 2024
@github-actions github-actions bot added the Bug Something isn't working label May 6, 2024
@ayushpahwa ayushpahwa added the ok-to-test Required label for CI label May 6, 2024
ankitakinger
ankitakinger previously approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@ankitakinger ankitakinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hetunandu
hetunandu reviewed May 6, 2024
View reviewed changes
app/client/src/pages/Editor/Explorer/Entity/index.tsx Outdated Show resolved Hide resolved
app/client/src/pages/Editor/Explorer/JSActions/JSActionEntity.tsx
@@ -92,7 +92,9 @@ export const ExplorerJSCollectionEntity = memo(
<Entity
action={navigateToJSCollection}
active={props.isActive}
canEditEntityName={canManageJSAction}
canEditEntityName={
canManageJSAction && !Boolean(jsAction?.isMainJSCollection)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isMainJSCollection is a EE concept right? Do we want to expose it out here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isMainJSCollection is currently used only for workflows (only set by server during workflows creation) but doesn't seem to be an issue to include it in CE also. This is in case it might be re-used for a CE use case.

@ayushpahwa ayushpahwa requested a review from hetunandu May 6, 2024 11:10
@ayushpahwa @hetunandu
fix: readability of classnames
300d2a0 
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
@ayushpahwa ayushpahwa requested a review from hetunandu May 6, 2024 11:31
@srix srix merged commit 022d457 into release May 6, 2024
13 checks passed
@srix srix deleted the fix/disable-main-js-rename branch May 6, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hetunandu hetunandu hetunandu approved these changes

@ankitakinger ankitakinger Awaiting requested review from ankitakinger

Assignees
No one assigned
Labels
Bug Something isn't working ok-to-test Required label for CI Task A simple Todo Workflows Pod For all issues related to the Workflows feature Workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task - Client]: Renaming of JS objects isn't happening properly from all the places.
4 participants
@ayushpahwa @hetunandu @ankitakinger @srix