fix: Add anonymous user check while registering the edit mode pulses

[abhvsn]

Description

PR to check if the usage is fired from an anonymous user in edit mode. Ideally, we don't expect the client to allow access in edit mode for anonymous user. We are also discussing if there are any cracks on client-side implementation in a separate thread.

Fixes https://github.com/appsmithorg/cloud-services/issues/1643

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8989771788
Commit: 675a0b2
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

[coderabbitai]

Walkthrough

Walkthrough

The recent modifications primarily involve the enhancement of boolean handling through the use of static imports for TRUE and FALSE constants, and adjustments in conditional logic. Additionally, there are updates to test cases in the UsagePulseServiceTest, including changes in the handling of viewMode and the introduction of a new test method to handle exceptions for anonymous users in edit mode.

Changes

File Path	Changes
.../services/ce/UsagePulseServiceCEImpl.java	Added static imports for FALSE and TRUE; adjusted conditional checks using these constants.
.../services/UsagePulseServiceTest.java	Added import for AppsmithException; modified test_AnonymousUserPulse_Success and createUsagePulse_forAppsmithCloud_pulseNotSavedInDB to set viewMode to true; added new test createPulse_inEditMode_withAnonymousUser_throwException.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between deb39ac and 675a0b2.

Files selected for processing (2)

• app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/UsagePulseServiceCEImpl.java (2 hunks)
• app/server/appsmith-server/src/test/java/com/appsmith/server/services/UsagePulseServiceTest.java (6 hunks)

Files skipped from review due to trivial changes (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/UsagePulseServiceCEImpl.java

Additional comments not posted (4)

app/server/appsmith-server/src/test/java/com/appsmith/server/services/UsagePulseServiceTest.java (4)

7-7: Added import for AppsmithException.

This import is necessary for handling exceptions in the new test scenarios that have been introduced.

---

Line range hint 53-64: Updated test_AnonymousUserPulse_Success to set viewMode to true.

This change ensures that the test accurately reflects the scenario where an anonymous user is in view mode, which is crucial for the new security measures being tested.

---

124-124: Updated createUsagePulse_forAppsmithCloud_pulseNotSavedInDB to set viewMode to true.

This change is consistent with the new logic introduced in the main application code, ensuring that the tests are aligned with the expected behavior.

---

141-154: Introduced new test method createPulse_inEditMode_withAnonymousUser_throwException.

This method correctly tests the new functionality that prevents anonymous users from accessing edit mode, aligning with the PR's security objectives.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Failed server tests

• com.appsmith.server.solutions.CreateDBTablePageSolutionTests#createPageWithLessColumnsComparedToTemplateForSql