fix: Fix OAuth2 client secret showing up in UI

[sharat87]

/ok-to-test tags="@tag.Sanity"

[sharat87]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8999852956.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33281.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-33281.dp.appsmith.com

[coderabbitai]

Walkthrough

Walkthrough

The modification in the code primarily focuses on enhancing the security of the OAuth2 configuration by altering the visibility of the clientSecret field. Specifically, the Views.Public annotation has been removed, ensuring that the clientSecret is no longer visible in public views, thus tightening security measures around sensitive data.

Changes

File Path	Change Summary
.../models/OAuth2.java	Removed Views.Public annotation from clientSecret. Changed visibility settings for RefreshTokenClientCredentialsLocation.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6ed49c2 and 7cfc2ee.

Files selected for processing (1)

• app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/OAuth2.java (1 hunks)

Additional comments not posted (1)

app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/OAuth2.java (1)

59-59: Change to restrict visibility of clientSecret enhances security.

Verification successful

---

The verification confirms that the clientSecret field in the OAuth2 class is no longer accessible from public views, aligning with the security enhancements intended in the pull request.

• No instances of clientSecret using Views.Public were found in the OAuth2 class.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the `clientSecret` field is no longer accessible from public views.

# Test: Search for any occurrences of `clientSecret` being accessed with `Views.Public`.
ast-grep --lang java --pattern $'@JsonView($$$) String clientSecret { $$$ }'

Length of output: 542

---

---

Script:

#!/bin/bash
# Description: Verify that the `clientSecret` field is no longer accessible from public views.

# Corrected Test: Search for any occurrences of `clientSecret` being accessed with `Views.Public`.
ast-grep --lang java --pattern $'class OAuth2 { @JsonView($$$) String clientSecret; }'

Length of output: 87

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.