fix: Removing the scrollbar in table widget when the data count is less than the number of rows being shown

[ankitakinger]

Description

Removing the scrollbar in table widget when the data count is less than the number of rows being shown for better user experience.

Fixes #17857

Automation

/ok-to-test tags="@tag.Table"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9003011050
Commit: 98f05ae
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

[coderabbitai]

Walkthrough

Walkthrough

The recent updates aim to enhance the height calculations for elements within the TableWidgetV2 component, improving visual consistency and presentation. Changes involve refining height calculations in the Table component and adjusting the height property in the TableVirtualBodyComponent.

Changes

File Path	Change Summary
app/client/src/widgets/TableWidgetV2/component/Table.tsx	Adjusted scrollContainerStyles height calculation based on props.data.length and props.pageSize.
app/client/src/widgets/TableWidgetV2/component/TableBody/index.tsx	Updated height calculation in TableVirtualBodyComponent to use props.tableSizes.VERTICAL_PADDING for padding.
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/scrollbar_spec.ts	Adjusted clientHeight comparison in Cypress test to include a scrollbar offset of 2 units.

Assessment against linked issues

Objective	Addressed	Explanation
Resolve scrollbar issue when fitting all items in the table window (#17857)	✅
Fix dropdown visibility and data loading issues in table within a list widget (#25436)	❌	The changes in this PR do not address the issues related to dropdown visibility and data loading in a table within a list widget.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bfb3b92 and 98f05ae.

Files selected for processing (1)

• app/client/src/widgets/TableWidgetV2/component/Table.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/client/src/widgets/TableWidgetV2/component/Table.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ankitakinger]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9001685088.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33290.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-33290.dp.appsmith.com