-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WDS, increase perceived darkness of modal overlay #33476
Conversation
WalkthroughWalkthroughThe recent changes in the theming files for both dark and light modes focus on adjusting the alpha transparency and lightness values of colors. These modifications aim to enhance the visual contrast and user experience, particularly for modal overlays. The dark mode theme now has a darker modal overlay, while the light mode theme features a slightly more opaque overlay. Changes
Assessment against linked issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review due to trivial changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Description
Closes #33276
![Screenshot 2024-05-15 at 10 59 31](https://private-user-images.githubusercontent.com/80973/330737267-27072d6b-fef5-422e-8b4e-36c678915b40.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2ODE4NDAsIm5iZiI6MTcyMDY4MTU0MCwicGF0aCI6Ii84MDk3My8zMzA3MzcyNjctMjcwNzJkNmItZmVmNS00MjJlLThiNGUtMzZjNjc4OTE1YjQwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzExVDA3MDU0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM2YWFkNjczYmVjZGI4ZjA0OGY3MWZiNjQ5MWJjNGYzOTU4ZWZhNjk5MDc0OTQ1ODc2ODlhODU4NmY5YzMxZDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Zluy1CQZ4KG6UE9S-7q_2txtZUZOltDMBsrDENWt0Yg)
By far the biggest impact on perceived darkness is dependent on transparency, adjusted it in light mode too just a little bit.
Automation
/ok-to-test tags="@tag.Anvil"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9092935034
Commit: d135655
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?