Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Scroll issues in Add tab #33595

Merged
merged 1 commit into from
May 20, 2024
Merged

fix: Scroll issues in Add tab #33595

merged 1 commit into from
May 20, 2024

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented May 20, 2024

Description

Ensures the parents of lists in add pane are defined in height so that the scrolling of lists can happen

Fixes #33585

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9157711114
Commit: d148c70
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@hetunandu hetunandu requested a review from sneha122 May 20, 2024 11:04
@hetunandu hetunandu added the ok-to-test Required label for CI label May 20, 2024
Copy link
Contributor

coderabbitai bot commented May 20, 2024

Walkthrough

Walkthrough

The changes involve adding the height="100%" attribute to several Flex components across different files. This adjustment ensures that these components take up the full height of their containers, potentially resolving issues related to scrolling and visibility in the split pane view of the editor.

Changes

Files Change Summary
app/client/.../JS/Add.tsx, app/client/.../Query/Add.tsx Added height="100%" attribute to <Flex> components to ensure full-height styling.
app/client/.../JSEditor/JSAddState.tsx, app/client/.../QueryEditor/QueriesAddState.tsx Modified <Flex> components to include height="100%", affecting the layout and ensuring full-height styling.

Assessment against linked issues

Objective Addressed Explanation
Ensure full visibility and scrollability of the list in split pane view (#33585)

These changes collectively aim to enhance the user experience by addressing the scrolling issue in the split pane view, allowing users to see the full list of datasources and add new queries easily.


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 49b7d1d and d148c70.
Files selected for processing (4)
  • app/client/src/pages/Editor/IDE/EditorPane/JS/Add.tsx (1 hunks)
  • app/client/src/pages/Editor/IDE/EditorPane/Query/Add.tsx (1 hunks)
  • app/client/src/pages/Editor/JSEditor/JSAddState.tsx (1 hunks)
  • app/client/src/pages/Editor/QueryEditor/QueriesAddState.tsx (1 hunks)
Files skipped from review due to trivial changes (4)
  • app/client/src/pages/Editor/IDE/EditorPane/JS/Add.tsx
  • app/client/src/pages/Editor/IDE/EditorPane/Query/Add.tsx
  • app/client/src/pages/Editor/JSEditor/JSAddState.tsx
  • app/client/src/pages/Editor/QueryEditor/QueriesAddState.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE Production Regressed Scenarios that were working before but have now regressed UX Improvement labels May 20, 2024
@hetunandu hetunandu merged commit 15203d2 into release May 20, 2024
43 of 44 checks passed
@hetunandu hetunandu deleted the fix/add-tab-scroll branch May 20, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production Regressed Scenarios that were working before but have now regressed UX Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Not able to scroll to add a new query or see the full list of datasources in split pane view
2 participants