-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add a warning icon and tooltip to indicate empty datasources #33618
Conversation
WalkthroughThe recent changes enhance the app's sidebar functionality to address users who skip connecting a datasource. A new tooltip and icon now indicate the absence of a connected datasource, ensuring users are informed about the missing configuration. These updates involve modifications to constants, component props, and logic for conditional rendering to support the new visual cues and messages. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9189021875. |
Deploy-Preview-URL: https://ce-33618.dp.appsmith.com |
…522-datasource-icon
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9202443250. |
Deploy-Preview-URL: https://ce-33618.dp.appsmith.com |
Description
Indicate the warning icon and display tooltip on hover of the sidebar datasource icon if no datasource is created in the current workspace, to nudge the users to create one.
Notion doc : https://www.notion.so/appsmith/Nudge-for-users-to-connect-their-own-datasource-c62b5194bae84383b6301e4fe2e3ad80#d9a140a4bbda4ed18ac95136990aa3e6
Figma : https://www.figma.com/design/kbU9xPv44neCfv1FFo9Ndu/User-Activation?node-id=5303-26410&t=skXEhNbpopbw1gYs-0
Fixes #30522
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.IDE"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9203050102
Commit: 6bb71c4
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?