Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the feature to download docker-compose file from admin settings #33682

Merged
merged 2 commits into from
May 23, 2024

Conversation

mohanarpit
Copy link
Member

@mohanarpit mohanarpit commented May 23, 2024

Description

Fixes #Issue Number

Automation

/ok-to-test tags="@tag.Settings,@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9203402018
Commit: 200f008
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Copy link
Contributor

coderabbitai bot commented May 23, 2024

Walkthrough

Walkthrough

The recent changes involve removing the functionality related to downloading the environment configuration file across various parts of the application. This includes deleting the associated API endpoint, settings, and methods in both the client and server codebases. The removal simplifies the codebase by eliminating the now redundant download feature.

Changes

Files Change Summary
app/client/src/ce/api/UserApi.tsx
app/client/src/ce/pages/AdminSettings/config/general.tsx
.../appsmith-server/src/main/java/com/appsmith/server/controllers/ce/InstanceAdminControllerCE.java
.../appsmith-server/src/main/java/com/appsmith/server/solutions/ce/EnvManagerCE.java
.../appsmith-server/src/main/java/com/appsmith/server/solutions/ce/EnvManagerCEImpl.java
Removed various download-related functionality including static URL, settings, and methods.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f0988f6 and 200f008.
Files selected for processing (1)
  • app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/EnvManagerTest.java (2 hunks)
Files skipped from review due to trivial changes (1)
  • app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/EnvManagerTest.java

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mohanarpit
Copy link
Member Author

/build-deploy-preview

@github-actions github-actions bot added the Bug Something isn't working label May 23, 2024
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9203174360.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33682.
recreate: .

@mohanarpit mohanarpit added the ok-to-test Required label for CI label May 23, 2024
@mohanarpit
Copy link
Member Author

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9203209919.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33682.
recreate: .

ankitakinger
ankitakinger previously approved these changes May 23, 2024
@mohanarpit mohanarpit added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 23, 2024
@mohanarpit
Copy link
Member Author

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9203683273.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33682.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-33682.dp.appsmith.com

Copy link
Contributor

@ankitakinger ankitakinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohanarpit mohanarpit merged commit 85f6340 into release May 23, 2024
42 checks passed
@mohanarpit mohanarpit deleted the fix/remove-docker-compose-download branch May 23, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working ok-to-test Required label for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants