Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new API getting added into the NA group #33701

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented May 23, 2024

Description

Alternate solution to #33627 to fix the NA group of newly created Rest API actions

Fixes #33583

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9218802021
Commit: 74c7bd4
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Copy link
Contributor

coderabbitai bot commented May 23, 2024

Walkthrough

The changes introduce a new variable pluginType of type PluginType in the ApiPaneSagas.ts file. This variable is assigned based on the apiType and is used in the payload for creating a default API action. This modification aims to address the issue where N/A was briefly displayed instead of APIs when creating a new query.

Changes

Files Change Summary
app/client/src/sagas/ApiPaneSagas.ts Introduced pluginType variable of type PluginType to set value based on apiType and included it in the payload for creating a default API action.

Assessment against linked issues

Objective (Issue #33583) Addressed Explanation
N/A displayed after creating a new query instead of an appropriate heading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE Production QA Needs QA attention QA Pod Issues under the QA Pod Regressed Scenarios that were working before but have now regressed UI Improvement labels May 23, 2024
@hetunandu hetunandu added ok-to-test Required label for CI and removed Bug Something isn't working UI Improvement QA Needs QA attention Low An issue that is neither critical nor breaks a user flow Production Regressed Scenarios that were working before but have now regressed Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE IDE Navigation Issues/feature requests related to IDE navigation, and context switching QA Pod Issues under the QA Pod labels May 23, 2024
@github-actions github-actions bot added Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage IDE Pod Issues that new developers face while exploring the IDE labels May 23, 2024
@github-actions github-actions bot added Production QA Needs QA attention QA Pod Issues under the QA Pod Regressed Scenarios that were working before but have now regressed UI Improvement labels May 23, 2024
@NilanshBansal
Copy link
Contributor

Re-triggering only GIT tests as only one GitBugs_Spec.ts is failing.

image

@NilanshBansal NilanshBansal added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 24, 2024
@NilanshBansal
Copy link
Contributor

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9218818243.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33701.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-33701.dp.appsmith.com

@NilanshBansal
Copy link
Contributor

Tested on DP. LGTM

@NilanshBansal NilanshBansal merged commit a74253b into release May 24, 2024
44 checks passed
@NilanshBansal NilanshBansal deleted the fix/api-NA-group branch May 24, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production QA Pod Issues under the QA Pod QA Needs QA attention Regressed Scenarios that were working before but have now regressed UI Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: N/A displayed after creating a new query instead of an appropriate heading
2 participants