fix: remove building blocks on canvas #33761
Conversation
WalkthroughWalkthroughThe changes remove the starter building blocks and related logic from the application. This includes deleting imports, action handlers, state properties, and conditional logic associated with starter building blocks. The aim is to simplify the codebase and improve user experience by eliminating confusing elements. Changes
Assessment against linked issues
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files not reviewed due to errors (1)
Additional context usedBiome
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
Building blocks
|
/build-deploy-preview |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9254226845. |
|
Deploy-Preview-URL: https://ce-33761.dp.appsmith.com |
Remove unused fields `isImportingStarterBuildingBlockToAppSelector` and `starterBuildingBlockDatasourcePromptSelector` from `templatesSelectors` to clean up the codebase and improve maintainability.
…o feat/33756/remove-bbs-on-canvas
rahulbarwal
added
ok-to-test
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9256298026. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
app/client/src/selectors/templatesSelectors.tsx (1)
Line range hint
241-243: Consider using afor...ofloop instead offorEachfor better performance and readability when iterating over templates.- templates.forEach((template) => { + for (const template of templates) { filterFilters(FUNCTIONS_FILTER, allFunctions, template); - }); + }app/client/src/ce/constants/ReduxActionConstants.tsx (1)
Line range hint
1186-1187: Replaceanywith more specific types to enhance type safety.- applications: any[]; + applications: ApplicationPayload[]; - cards: { [id: string]: WidgetCardProps[] }; + cards: { [id: string]: WidgetCardProps[] };Also applies to: 1279-1279
app/client/src/ce/constants/messages.ts (3)
Line range hint
4-4: Consider specifying a more explicit type instead ofanyforstrArgsin thecreateMessagefunction to enhance type safety and code maintainability.- format: (...strArgs: any[]) => string, + format: (...strArgs: string[]) => string,
Line range hint
5-5: Consider specifying a more explicit type instead ofanyforargsin thecreateMessagefunction to enhance type safety and code maintainability.- ...args: any[] + ...args: string[]
Line range hint
16-47: Avoid using template literals when there is no string interpolation or special character handling required. This can improve code readability and performance.- export const APPSMITH_DISPLAY_VERSION = (edition: string, version: string) => - `Appsmith ${edition} ${version}`; + export const APPSMITH_DISPLAY_VERSION = (edition: string, version: string) => + "Appsmith " + edition + " " + version;Apply similar changes to all other instances where template literals are used unnecessarily.
|
Deploy-Preview-URL: https://ce-33761.dp.appsmith.com |
rahulbarwal
added
ok-to-test
|
DP is failing here |
…gBlockExplorerDropTarget This commit refactors the OnBoarding component to conditionally render the BuildingBlockExplorerDropTarget based on certain conditions. The conditions include the instance being airgapped, the editor state, the UI segment, and the releaseDragDropBuildingBlocksEnabled flag. This change improves the codebase by removing unnecessary code and improving maintainability.
rahulbarwal
added
ok-to-test
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9265706807. |
@pratapaprasanna just saw this. What can we do about this? Is this a concern? |
|
Deploy-Preview-URL: https://ce-33761.dp.appsmith.com |
rahulbarwal
added
ok-to-test
…o feat/33756/remove-bbs-on-canvas
rahulbarwal
added
ok-to-test
rahulbarwal
added
ok-to-test
Description
Removes building blocks on canvas feature.
Fixes #33756
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9312996633
Commit: f8059cc
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?