fix: make individual words in label selectable #22110

[alex-golovanov]

Description

Individual words in debugger messages can now be selected.

Fixes #22110

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9370104155
Commit: 2fe1821
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

[coderabbitai]

Walkthrough

Walkthrough

The changes in the LogItem.tsx file involve removing vendor-specific CSS properties that were affecting text selection within the debugger output. This modification aims to resolve an issue where users were unable to select part of the console log output, making text selection more user-friendly.

Changes

File Path	Change Summary
app/client/src/components/editorComponents/.../LogItem.tsx	Removed vendor-specific CSS properties related to user selection to improve text selection behavior.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Fix text selection in debugger output to allow partial selection (#22110)	✅

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4b50a7f and 2fe1821.

Files selected for processing (1)

• app/client/src/components/editorComponents/Debugger/LogItem.tsx (1 hunks)

Additional context used

Biome

app/client/src/components/editorComponents/Debugger/LogItem.tsx

[error] 44-44: Do not use template literals if interpolation and special-character handling are not needed.

---

[error] 45-45: Do not use template literals if interpolation and special-character handling are not needed.

---

[error] 182-186: Prefer for...of instead of forEach.

---

[error] 219-219: Unexpected any. Specify a different type.

---

[error] 220-220: Unexpected any. Specify a different type.

---

[error] 296-299: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.

---

[error] 366-366: Unexpected any. Specify a different type.

---

[error] 377-383: This else clause can be omitted because previous branches break early.

---

[error] 267-267: Use Number.parseInt instead of the equivalent global.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (6)

app/client/src/components/editorComponents/Debugger/LogItem.tsx (6)

Line range hint 44-45: Avoid using template literals where not necessary.

- ${(props) => props.collapsed ? `transform: rotate(-90deg);` : `transform: rotate(0deg); `};
+ ${(props) => props.collapsed ? "transform: rotate(-90deg);" : "transform: rotate(0deg);"};

---

Line range hint 182-186: Prefer using for...of instead of forEach for better performance and readability.

- e.logData.forEach((item) => {
-   if (typeof item === "object") {
-     output = true;
-   }
- });
+ for (const item of e.logData) {
+   if (typeof item === "object") {
+     output = true;
+     break;
+   }
+ }

---

Line range hint 219-220: Specify a more explicit type instead of any.

Please replace any with a more specific type to improve type safety and code readability.

Also applies to: 366-366

---

Line range hint 296-299: Ensure accessibility by pairing mouse events with keyboard events.

Consider adding onKeyUp, onKeyDown, or onKeyPress events alongside onClick to improve accessibility.

---

Line range hint 377-383: Remove unnecessary else clause.

- } else {
-   return (
-     <span className="debugger-label" key={Math.random()}>
-       {`${logDatum} `}
-     </span>
-   );
- }

This else clause is redundant since the previous branches already return early.

---

Line range hint 267-267: Use Number.parseInt for parsing integers.

- moment(parseInt(props.timestamp)).format("HH:mm:ss")
+ moment(Number.parseInt(props.timestamp, 10)).format("HH:mm:ss")

[alex-golovanov]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9347931207.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33922.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-33922.dp.appsmith.com