Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: currency prefix #34039

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: currency prefix #34039

merged 1 commit into from
Jun 6, 2024

Conversation

KelvinOm
Copy link
Collaborator

@KelvinOm KelvinOm commented Jun 6, 2024

Description

Fix currency prefix

Fixes #33932

Automation

/ok-to-test tags="@tag.Anvil"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9400580646
Commit: 47a64f0
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor
    • Improved the code structure of the currency input component for better readability and maintainability.

@github-actions github-actions bot added Anvil Pod Issue related to Anvil project Bug Something isn't working Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users WDS team labels Jun 6, 2024
@KelvinOm KelvinOm added skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-docs skip-testPlan ok-to-test Required label for CI labels Jun 6, 2024
@github-actions github-actions bot removed the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jun 6, 2024
Copy link
Contributor

coderabbitai bot commented Jun 6, 2024

Walkthrough

The recent update to the CurrencyInputComponent in index.tsx introduces a new constant prefix to handle the JSX element for the currency symbol. This change addresses the text overlap issue when the currency symbol has more than one character by ensuring proper styling and placement within the TextInput component.

Changes

Files Change Summary
app/client/src/widgets/wds/WDSCurrencyInputWidget/component/index.tsx Introduced a new constant prefix for the JSX element representing the currency symbol, replacing inline JSX.

Sequence Diagram(s) (Beta)

No sequence diagrams are necessary for this change as it is a simple refactor to improve styling.

Assessment against linked issues

Objective Addressed Explanation
Fix text overlap on the currency widget when the currency symbol has more than one character (#33932)

Poem

In the land of code so bright,
A currency symbol took flight.
With a prefix now in place,
Overlaps have left no trace.
Widgets shine with symbols clear,
Bugs and glitches disappear!
🎉🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 33b3949 and 47a64f0.

Files selected for processing (1)
  • app/client/src/widgets/wds/WDSCurrencyInputWidget/component/index.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
  • app/client/src/widgets/wds/WDSCurrencyInputWidget/component/index.tsx

@KelvinOm KelvinOm merged commit 001acca into release Jun 6, 2024
58 of 63 checks passed
@KelvinOm KelvinOm deleted the fix/currency-prefix branch June 6, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil Pod Issue related to Anvil project Bug Something isn't working Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users ok-to-test Required label for CI skip-docs WDS team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Text overlap on the currency widget when currency has more than one character
2 participants