-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: code split for run history resize issue in workflows editor #34049
Conversation
WalkthroughThe recent changes introduce a new Changes
Poem
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- app/client/src/ce/components/RunHistory/index.tsx (1 hunks)
- app/client/src/ee/components/RunHistory/index.tsx (1 hunks)
- app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx (2 hunks)
- app/client/src/pages/Editor/JSEditor/Form.tsx (2 hunks)
- app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx (2 hunks)
Files skipped from review due to trivial changes (2)
- app/client/src/ce/components/RunHistory/index.tsx
- app/client/src/ee/components/RunHistory/index.tsx
Additional comments not posted (6)
app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx (2)
43-43
: Import ofRunHistory
looks good.
390-390
: Integration of<RunHistory />
component appears correctly placed within the UI structure.#!/bin/bash # Description: Verify that the RunHistory component is properly integrated and functional. # Test: Search for the component usage in related test files. Expect: Relevant test cases covering the new component. rg --type typescript $'describe\(.*RunHistory.*\)'app/client/src/pages/Editor/JSEditor/Form.tsx (2)
74-74
: Import ofRunHistory
looks good.
444-444
: Integration of<RunHistory />
component appears correctly placed within the UI structure.#!/bin/bash # Description: Verify that the RunHistory component is properly integrated and functional. # Test: Search for the component usage in related test files. Expect: Relevant test cases covering the new component. rg --type typescript $'describe\(.*RunHistory.*\)'app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx (2)
64-64
: Import ofRunHistory
looks good.
750-750
: Integration of<RunHistory />
component appears correctly placed within the UI structure.#!/bin/bash # Description: Verify that the RunHistory component is properly integrated and functional. # Test: Search for the component usage in related test files. Expect: Relevant test cases covering the new component. rg --type typescript $'describe\(.*RunHistory.*\)'
Description
Run history for workflows is a system wide pane but due to the nature of the panes in appsmith, a pane has to be individually imported to each editor (jsobject, query,data and api). This PR is the code split PR which imports the pane into the respective component. The logic for the pane is in EE and can only be opened by a trigger that is only in workflow editor. EE PR for reference.
Fixes #33024
Automation
/test ide
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9403599136
Commit: 3d5d2c1
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
RunHistory
component to track and display run history in various editors.Enhancements
RunHistory
component to API Editor, JS Editor, and Query Editor for improved user experience.These updates aim to provide better visibility and tracking of run histories across different sections of the application.