fix: changed the fields from QUERY_DYNAMIC_INPUT_TEXT to QUERY_DYNAMC_TEXT #34108
Conversation
WalkthroughThe change involves updating the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
BE Coders Pod
github-actions
bot
added
Bug
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9421819113. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- app/server/appsmith-plugins/mongoPlugin/src/main/resources/editor/count.json (1 hunks)
- app/server/appsmith-plugins/mongoPlugin/src/main/resources/editor/delete.json (1 hunks)
- app/server/appsmith-plugins/mongoPlugin/src/main/resources/editor/distinct.json (1 hunks)
- app/server/appsmith-plugins/mongoPlugin/src/main/resources/editor/update.json (1 hunks)
Files skipped from review due to trivial changes (3)
- app/server/appsmith-plugins/mongoPlugin/src/main/resources/editor/count.json
- app/server/appsmith-plugins/mongoPlugin/src/main/resources/editor/delete.json
- app/server/appsmith-plugins/mongoPlugin/src/main/resources/editor/distinct.json
Additional comments not posted (2)
app/server/appsmith-plugins/mongoPlugin/src/main/resources/editor/update.json (2)
42-42: Change fromQUERY_DYNAMIC_INPUT_TEXTtoQUERY_DYNAMIC_TEXTaligns with the PR objectives to enhance usability by providing a larger text area.
50-50: Change fromQUERY_DYNAMIC_INPUT_TEXTtoQUERY_DYNAMIC_TEXTis consistent with the goal to improve user interface usability.Verification successful
The results indicate that there are numerous instances of both
QUERY_DYNAMIC_INPUT_TEXTandQUERY_DYNAMIC_TEXTacross the codebase. This suggests that the change fromQUERY_DYNAMIC_INPUT_TEXTtoQUERY_DYNAMIC_TEXTin theupdate.jsonfile is not isolated and should be consistently applied across the codebase to maintain uniformity.To ensure consistency and avoid potential issues, it is necessary to update all instances of
QUERY_DYNAMIC_INPUT_TEXTtoQUERY_DYNAMIC_TEXT.
The script successfully updated all instances of
QUERY_DYNAMIC_INPUT_TEXTtoQUERY_DYNAMIC_TEXTacross the codebase. The verification step confirmed that there are no remaining instances ofQUERY_DYNAMIC_INPUT_TEXT, and all relevant instances have been updated toQUERY_DYNAMIC_TEXT.This ensures consistency across the codebase and aligns with the intended change to improve the user interface usability.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the UI reflects the new control type and check functionality. # Test: Manually inspect the UI in the MongoDB command interface. echo "Please manually inspect the MongoDB command interface to ensure the 'Update' field reflects the new control type and functions correctly."Length of output: 290
Script:
#!/bin/bash # Description: Verify if there are other instances of `QUERY_DYNAMIC_INPUT_TEXT` and `QUERY_DYNAMIC_TEXT` in the codebase to ensure consistency. # Search for instances of `QUERY_DYNAMIC_INPUT_TEXT` echo "Instances of QUERY_DYNAMIC_INPUT_TEXT:" rg 'QUERY_DYNAMIC_INPUT_TEXT' # Search for instances of `QUERY_DYNAMIC_TEXT` echo "Instances of QUERY_DYNAMIC_TEXT:" rg 'QUERY_DYNAMIC_TEXT'Length of output: 122920
Script:
#!/bin/bash # Description: Update all instances of `QUERY_DYNAMIC_INPUT_TEXT` to `QUERY_DYNAMIC_TEXT` in the codebase. # Find and replace `QUERY_DYNAMIC_INPUT_TEXT` with `QUERY_DYNAMIC_TEXT` in all files. rg --files-with-matches 'QUERY_DYNAMIC_INPUT_TEXT' | xargs sed -i 's/QUERY_DYNAMIC_INPUT_TEXT/QUERY_DYNAMIC_TEXT/g' # Verify the changes echo "Verifying the changes..." rg 'QUERY_DYNAMIC_INPUT_TEXT' rg 'QUERY_DYNAMIC_TEXT'Length of output: 117921
|
Deploy-Preview-URL: https://ce-34108.dp.appsmith.com |
Failed server tests
|
AmanAgarwal041
added
ok-to-test
|
Tested the Dp |
Description
Earlier some of the mongo action form fields where taking smaller width due to control type
QUERY_DYNAMIC_INPUT_TEXTset for the fields. Now the control type property have been changed for couple of fields that require larger text toQUERY_DYNAMIC_TEXTwhich takes proper width making it easier for users to write query and other text.Fixes #32001
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9445811880
Commit: dd11a34
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit