fix: revert to passing hook as a prop for EE compatibility #34367
Conversation
WalkthroughThe changes involve refactoring the navigation menu logic in the application's editor components. The Changes
Assessment against linked issues
Poem
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
IDE Navigation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- app/client/src/pages/Editor/EditorHeader.tsx (2 hunks)
- app/client/src/pages/Editor/EditorName/index.tsx (3 hunks)
- app/client/src/pages/Editor/IDE/Header/index.tsx (2 hunks)
Additional comments not posted (6)
app/client/src/pages/Editor/EditorName/index.tsx (3)
16-17: Ensure thatNavigationMenuDataPropsandMenuItemDataare used correctly in the context of the reverted changes.#!/bin/bash # Description: Verify the usage of NavigationMenuDataProps and MenuItemData in other parts of the codebase. # Test: Search for these types in other TypeScript files. rg --type ts "NavigationMenuDataProps|MenuItemData"
35-38: ThegetNavigationMenuprop is now expected to be a function that takesNavigationMenuDataPropsand returns an array ofMenuItemData. Ensure that all usages of this prop are updated accordingly across the project.#!/bin/bash # Description: Check if `getNavigationMenu` is correctly implemented everywhere it's used. # Test: Search for the usage of the `getNavigationMenu` prop. rg --type ts "getNavigationMenu"
101-101: The implementation ofgetNavigationMenuhere should be validated to ensure it adheres to the expected behavior, especially after the revert changes.#!/bin/bash # Description: Verify the correct implementation of `getNavigationMenu`. # Test: Search for the function definition and usage to ensure it matches the expected behavior. rg --type ts "getNavigationMenu"app/client/src/pages/Editor/EditorHeader.tsx (2)
49-49: The import ofuseNavigationMenuDatais crucial for the reverted functionality. Ensure that this hook is correctly implemented and used in the context of this component.#!/bin/bash # Description: Verify the correct implementation and usage of `useNavigationMenuData`. # Test: Search for the definition and usage of `useNavigationCOURSE_DATA` in the TypeScript files. rg --type ts "useNavigationMenuData"
211-211: Confirm thatgetNavigationMenuis used correctly here, especially after changes to ensure it aligns with the expected functionality and interface.#!/bin/bash # Description: Verify the correct usage of `getNavigationMenu` in `EditorHeader`. # Test: Search for the usage of `getNavigationMenu` to ensure it matches the expected behavior. rg --type ts "getNavigationMenu"app/client/src/pages/Editor/IDE/Header/index.tsx (1)
79-79: The import ofuseNavigationMenuDatahere is essential for the reverted functionality. Verify that this hook is correctly implemented and utilized in this component's context.#!/bin/bash # Description: Verify the correct implementation and usage of `useNavigationMenuData`. # Test: Search for the definition and usage of `useNavigationMenuData` in the TypeScript files. rg --type ts "useNavigationMenuData"
## Description Reverted missed out code in #34367 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9608916182> > Commit: a252566 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9608916182&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No
Description
Revert to passing hook as a prop for EE compatibility.
Fixes #32982
Automation
/ok-to-test tags="@tag.IDE"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9600106265
Commit: 042f945
Cypress dashboard.
Tags:
@tag.IDECommunication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Refactor
Bug Fixes