-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return hint on localhost url #3611
Return hint on localhost url #3611
Conversation
...ver/appsmith-interfaces/src/main/java/com/appsmith/external/models/DatasourceTestResult.java
Outdated
Show resolved
Hide resolved
...server/appsmith-server/src/main/java/com/appsmith/server/services/DatasourceServiceImpl.java
Show resolved
Hide resolved
app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java
Show resolved
Hide resolved
…rnal/models/DatasourceTestResult.java Co-authored-by: Trisha Anand <trisha@appsmith.com>
…o feature/return_hint_on_localhost_url_with_get_all
…ttps://github.com/appsmithorg/appsmith into feature/return_hint_on_localhost_url_with_get_all
app/server/appsmith-server/src/main/java/com/appsmith/server/exceptions/AppsmithError.java
Outdated
Show resolved
Hide resolved
...server/appsmith-server/src/main/java/com/appsmith/server/services/DatasourceServiceImpl.java
Outdated
Show resolved
Hide resolved
app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java
Outdated
Show resolved
Hide resolved
app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java
Show resolved
Hide resolved
- remove unused errors. - handle null datasource properly
...server/appsmith-server/src/main/java/com/appsmith/server/services/DatasourceServiceImpl.java
Outdated
Show resolved
Hide resolved
…ervices/DatasourceServiceImpl.java
@sumitsum Thanks for fixing this. I have a suggestion about the message. Instead of just saying please check Appsmith documentation, is there a solution we can suggest in the message itself? Like please expose your local endpoint to the internet before trying to access it inside Appsmith. If there's no such answer, then I understand. Also is there a documentation link for this message? |
Hi @areyabhishek , Yes I can change the message to include one possible solution that should cover ground for most of the users. I can change it to something like this: We don't have a documentation for this yet, but I will update it soon to include details about this message. This message is not yet displayed to the user because the client side changes have not come in. I will update the documentation before that happens. |
Description
Fixes #552
Type of change
How Has This Been Tested?
Test datasource response:
————————
{"responseMeta":{"status":200,"success":true},"data":{"invalids":["Missing username for authentication."], "messages":["You may not able to access localhost if Appsmith is running inside a docker container"], "success":false}}
Save datasource response:
————————
{"responseMeta":{"status":200,"success":true},"data":{"id":"6052f64a0f724760d3e94a23","userPermissions":["execute:datasources","manage:datasources","read:datasources"],"name":"Untitled Datasource 5467","pluginId":"5c9f512f96c1a50004819786","organizationId":"5f9fc0550b682b2a63e424d3","datasourceConfiguration":{"connection":{"mode":"READ_WRITE"},"endpoints":[{"host":"localhost"}],"authentication":{"authenticationType":"dbAuth","authenticationType":"dbAuth","databaseName":"admin"},"sshProxyEnabled":false},"invalids":["Missing username for authentication."],"messages":["You may not able to access localhost if Appsmith is running inside a docker container"]
,"isValid":false,"new":false}}API URL update response:
———————————
{"responseMeta":{"status":200,"success":true},"data":{"id":"60530960bf7f4b4dceae17aa","organizationId":"5f9fc0550b682b2a63e424d3","pluginType":"API","pluginId":"5ca385dc81b37f0004b4db85","name":"Api6","datasource":{"userPermissions":[],"name":"DEFAULT_REST_DATASOURCE","pluginId":"5ca385dc81b37f0004b4db85","organizationId":"5f9fc0550b682b2a63e424d3","datasourceConfiguration":{
"url":"http://localhost"`},"invalids":[],`"messages":["You may not able to access localhost if Appsmith is running inside a docker container"],"isValid":true,"new":true},"pageId":"60211622f3d65469ffa7d5f5","actionConfiguration":{"timeoutInMillisecond":10000,"paginationType":"NONE","headers":[{"key":"","value":""},{"key":"","value":""}],"encodeParamsToggle":true,"queryParameters":[{"key":"","value":""},{"key":"","value":""}],"httpMethod":"GET"},"executeOnLoad":false,"dynamicBindingPathList":[],"isValid":true,"invalids":[],"jsonPathKeys":[],"confirmBeforeExecute":false,"userPermissions":["read:actions","execute:actions","manage:actions"]}}
API save as datasource response:
————————————
{"responseMeta":{"status":201,"success":true},"data":{"id":"605309f5bf7f4b4dceae17ab","userPermissions":["execute:datasources","manage:datasources","read:datasources"],"name":"Untitled Datasource 5468","pluginId":"5ca385dc81b37f0004b4db85","organizationId":"5f9fc0550b682b2a63e424d3","datasourceConfiguration":{"properties":[{"key":"isSendSessionEnabled","value":"N"},{"key":"sessionSignatureKey"}],
"url":"http://localhost"`},"invalids":[],`"messages":["You may not able to access localhost if Appsmith is running inside a docker container"],"isValid":true,"new":false}}
Fetch datasource info on page load response:
—————————————
{"id":"6051d88334f958353c5ae719","userPermissions":["execute:datasources","manage:datasources","read:datasources"],"name":"Untitled Datasource 5460","pluginId":"5ca385dc81b37f0004b4db85","organizationId":"5f9fc0550b682b2a63e424d3","datasourceConfiguration":{"authentication":{"authenticationType":"oAuth2","grantType":"client_credentials","isTokenHeader":true,"isAuthorizationHeader":false,"headerPrefix":"Bearer "},"sshProxyEnabled":false,"properties":[{"key":"isSendSessionEnabled","value":"N"},{"key":"sessionSignatureKey","value":""}],
"url":"https://localhost",`"headers":[]},"invalids":["Missing Client Secret","Missing Client ID","Missing Access Token URL"],"messages":["You may not able to access localhost if Appsmith is running inside a docker container"]
,"isValid":false,"new":false},`{"id":"6051db4bec994c15970cc8a3","userPermissions":["execute:datasources","manage:datasources","read:datasources"],"name":"Untitled Datasource 5461","pluginId":"5ca385dc81b37f0004b4db85","organizationId":"5f9fc0550b682b2a63e424d3","datasourceConfiguration":{"authentication":{"authenticationType":"oAuth2","grantType":"client_credentials","isTokenHeader":true,"isAuthorizationHeader":false,"headerPrefix":"Bearer "},"sshProxyEnabled":false,"properties":[{"key":"isSendSessionEnabled","value":"N"},{"key":"sessionSignatureKey","value":""}],
"url":"https://localhost"`,"headers":[]},"invalids":["Missing Client Secret","Missing Client ID","Missing Access Token URL"],"messages":["You may not able to access localhost if Appsmith is running inside a docker container"]
,"isValid":false,"new":false},`{"id":"6051db8fec994c15970cc8a4","userPermissions":["execute:datasources","manage:datasources","read:datasources"],"name":"Untitled Datasource 5462","pluginId":"5ca385dc81b37f0004b4db85","organizationId":"5f9fc0550b682b2a63e424d3","datasourceConfiguration":{"properties":[{"key":"isSendSessionEnabled","value":"N"},{"key":"sessionSignatureKey"}],
"url":"https://localhost"`},"invalids":[],`"messages":["You may not able to access localhost if Appsmith is running inside a docker container"],"isValid":true,"new":false},
Checklist: