Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle image download error #5951

Merged
merged 1 commit into from
Jul 22, 2021
Merged

handle image download error #5951

merged 1 commit into from
Jul 22, 2021

Conversation

techbhavin
Copy link
Contributor

@techbhavin techbhavin commented Jul 19, 2021

Description

Added function for Download image in new tab

Fixes #5764

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 馃И

馃敶 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: bug/image-dwnload-cors 
Status File % Stmts % Branch % Funcs % Lines
馃敶 total 53.58 (-0.01) 35.32 (0) 32.12 (0) 54.13 (-0.02)
馃敶 app/client/src/components/designSystems/appsmith/ImageComponent.tsx 15.84 (-1.18) 15.63 (0) 8.33 (-0.37) 16.67 (-1.4)

Copy link
Contributor

@somangshu somangshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vivekverma2312
Copy link

@techbhavin Tested this on deploy preview and it's working fine as per the comment #5764 (comment)

@somangshu somangshu merged commit c23925c into release Jul 22, 2021
@somangshu somangshu deleted the bug/image-dwnload-cors branch July 22, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Download is not functional on image widget if we pass URL in image property
3 participants