-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Authenticated API datasource creation #6017
Conversation
/ok-to-test sha=f902bf5 |
/ok-to-test sha=c06434f |
@pranavkanade small change, can we call this authenticated API instead of OAuth |
/ok-to-test sha=cc6787d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we redirect to the view mode of the datasource after saving it, which has a create new query button? We could keep them on the same page as well since there's a new api button here.
Also we should keep the new api button disabled button until we save the datasource, as it still errors out even if the url is filled
@rishabhsaxena the new API button from edit mode needs to be removed, it's confusing. Redirecting to the view mode is to give reinforcement that it got saved and the next step is to create a new API |
@Nikhil-Nandagopal will add saved state for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rishabh-Rathod this is a bug. I can see that on release as well. |
/ok-to-test sha=72efc2a |
@@ -154,10 +154,14 @@ function NewApiScreen(props: Props) { | |||
}, [plugins]); | |||
|
|||
const handleCreateAuthApiDatasource = useCallback(() => { | |||
authApiPlugin && | |||
if (authApiPlugin) { | |||
AnalyticsUtil.logEvent("CREATE_DATA_SOURCE_AUTH_API_CLICK", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_CLICK
I guess this suffix would be useful to differentiate b/w frontend / backend events as well
Description
Added a new card to datasources pane to create REST API datasource, directly from
create new
tab.Fixes #5782
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 馃И
馃敶 Total coverage has decreased