Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linting error for list widget #7245

Closed
wants to merge 1 commit into from

Conversation

jsartisan
Copy link
Contributor

@jsartisan jsartisan commented Sep 8, 2021

The list widget children were giving a linting error when currentIndex was not used in the binding.

Fixes #7190

Type of change

Please delete options that are not relevant.

  • Bug fix

How Has This Been Tested?

  • manually tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed
// Code coverage diff between base branch:release and head branch: fix/list-widget-linting-bug 
Status File % Stmts % Branch % Funcs % Lines
🔴 app/client/src/mockResponses/WidgetConfigResponse.tsx 14.55 (-0.26) 0 (0) 0 (0) 15.53 (-0.31)
🟢 app/client/src/utils/autocomplete/TernServer.ts 50.71 (0.24) 39.13 (0.87) 36.21 (0) 55.35 (0.27)

@github-actions github-actions bot added the Bug Something isn't working label Sep 8, 2021
@github-actions
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Sep 15, 2021
@github-actions
Copy link

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this Sep 22, 2021
@mohanarpit mohanarpit deleted the fix/list-widget-linting-bug branch October 8, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Release] Getting error in connection establisher for List widgets
1 participant