Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle socket exception for write events. #7818

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

pranavkanade
Copy link
Contributor

@pranavkanade pranavkanade commented Sep 24, 2021

Description

Logging the error to sentry

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/handle-socket-exception 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 54.89 (-0.01) 37.04 (-0.03) 33.88 (-0.01) 55.5 (-0.01)
🔴 app/client/src/pages/Editor/RealtimeAppEditors.tsx 88.46 (0) 31.25 (-2.08) 62.5 (0) 88.46 (0)
🟢 app/client/src/sagas/WebsocketSagas/WebsocketSagas.ts 18.75 (0.72) 11.76 (0) 13.33 (0) 21.82 (0.67)
🔴 app/client/src/utils/helpers.tsx 64.93 (-2.37) 36.89 (-4.86) 42.86 (-2.85) 62.05 (-2.41)

@pranavkanade pranavkanade added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 24, 2021
@github-actions github-actions bot added Bug Something isn't working and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Sep 24, 2021
@pranavkanade pranavkanade merged commit 79f613c into release Sep 24, 2021
@pranavkanade pranavkanade deleted the fix/handle-socket-exception branch September 24, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants