Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgraded socket.io client package to latest stable version #7845

Merged
merged 2 commits into from
Sep 27, 2021
Merged

fix: upgraded socket.io client package to latest stable version #7845

merged 2 commits into from
Sep 27, 2021

Conversation

pranavkanade
Copy link
Contributor

@pranavkanade pranavkanade commented Sep 27, 2021 •
edited by github-actions bot

Description

package upgrade from v4.0.0 to v4.2.0

Fixes #7710

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • already have automated test

Test coverage results 馃И

馃煝 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: fix/socket-io-client-package-upgrade
Status File % Stmts % Branch % Funcs % Lines
馃煝 total 54.86 (0) 37 (0.01) 33.86 (0) 55.49 (0.01)
馃煝 app/client/src/utils/autocomplete/TernServer.ts 50.71 (0.24) 39.13 (0.87) 36.21 (0) 55.35 (0.27)

@github-actions github-actions bot added the Bug Something isn't working label Sep 27, 2021
rishabhsaxena
rishabhsaxena previously approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@rishabhsaxena rishabhsaxena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we can keep it auto update till the next major?

app/client/package.json Outdated Show resolved Hide resolved
@pranavkanade pranavkanade added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 27, 2021
@pranavkanade @rishabhsaxena
auto update enabled
21e5595 
Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>
@pranavkanade pranavkanade merged commit db02756 into release Sep 27, 2021
@pranavkanade pranavkanade deleted the fix/socket-io-client-package-upgrade branch September 27, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhsaxena rishabhsaxena rishabhsaxena approved these changes

@rishabhrathod01 rishabhrathod01 rishabhrathod01 approved these changes

@sbalaji1192 sbalaji1192 Awaiting requested review from sbalaji1192

Assignees
No one assigned
Labels
Bug Something isn't working skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Error: Transport not open
3 participants
@pranavkanade @rishabhsaxena @rishabhrathod01