Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing table widget updatehook #7992

Merged
merged 7 commits into from
Oct 26, 2021
Merged

fix: fixing table widget updatehook #7992

merged 7 commits into from
Oct 26, 2021

Conversation

Tooluloope
Copy link
Contributor

@Tooluloope Tooluloope commented Sep 30, 2021 •
edited by github-actions bot

Description

fixing table widget updatehook

Fixes #7536
Fixes #8379

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed No changes to code coverage between the base branch and the head branch

@Tooluloope Tooluloope added the UI Builders Pod Issues that UI Builders face using appsmith label Sep 30, 2021
@github-actions github-actions bot added the Bug Something isn't working label Sep 30, 2021
@Tooluloope Tooluloope added UI Building Pod and removed UI Builders Pod Issues that UI Builders face using appsmith labels Sep 30, 2021
@somangshu somangshu closed this Oct 7, 2021
@Tooluloope Tooluloope mentioned this pull request Oct 11, 2021
Closed
@riodeuno riodeuno reopened this Oct 11, 2021
@riodeuno riodeuno assigned Tooluloope and unassigned jsartisan Oct 11, 2021
jsartisan
jsartisan previously approved these changes Oct 11, 2021
View reviewed changes
@vivekverma2312
Copy link

@Tooluloope Working fine on Deploy Preview.

@somangshu somangshu added the App Viewers Pod This label assigns issues to the app viewers pod label Oct 15, 2021
@Tooluloope
Copy link
Contributor Author

/ok-to-test sha=e24bfee

1 similar comment
@Tooluloope
Copy link
Contributor Author

/ok-to-test sha=e24bfee

@Tooluloope
Copy link
Contributor Author

https://github.com/appsmithorg/appsmith/runs/3962909391?check_suite_focus=true

@Tooluloope
Copy link
Contributor Author

/ok-to-test sha=99c740c

@Tooluloope Tooluloope merged commit e4caaac into release Oct 26, 2021
@Tooluloope Tooluloope deleted the fix/Table-Widget-update-hook branch October 26, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsartisan jsartisan jsartisan approved these changes

Assignees

@Tooluloope Tooluloope

Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working
Projects
None yet
Milestone
No milestone
5 participants
@Tooluloope @vivekverma2312 @jsartisan @riodeuno @somangshu