Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #8042 updated divider widget height width and default color #8304

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

vibhandikyash
Copy link
Contributor

@vibhandikyash vibhandikyash commented Oct 7, 2021

Description

Added cosmetic effects for Divider.

Fixes #8042

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested Locally.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed No changes to code coverage between the base branch and the head branch

@vibhandikyash vibhandikyash added the UI Builders Pod Issues that UI Builders face using appsmith label Oct 7, 2021
@vibhandikyash vibhandikyash self-assigned this Oct 7, 2021
@github-actions github-actions bot added the Bug Something isn't working label Oct 7, 2021
@vibhandikyash vibhandikyash marked this pull request as ready for review October 8, 2021 08:42
Copy link
Contributor

@somangshu somangshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, But visually the divider is least visible on the canvas

@momcilo-appsmith kindly check this out

@vivekverma2312 you will have to verify the rest of the changes, and also check if anything is missed here

@somangshu somangshu changed the title fix: #8042 updated dropped height width and default color fix: #8042 updated divider widget height width and default color Oct 11, 2021
@somangshu somangshu added UI Building Pod App Viewers Pod This label assigns issues to the app viewers pod and removed UI Builders Pod Issues that UI Builders face using appsmith labels Oct 12, 2021
@shwetha-ramesh
Copy link

@vibhandikyash tested this PR with reference to the attached document :
issue 1 : hover state is not highlighting the widget in 'blue'
issue 2 : clicking on the widget does not change the color to 'blue'

https://loom.com/share/80fdecc9865c4d71af6e30b0d20b54ee

@vibhandikyash
Copy link
Contributor Author

@shwetha-ramesh @YogeshJayaseelan It's a feature of Figma and not a hover action.

@vibhandikyash vibhandikyash merged commit a461c2d into release Oct 26, 2021
@vibhandikyash vibhandikyash deleted the fix/8042-design-audit-divider-widget branch October 26, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Widget design audit: Divider Widget
3 participants