fix: Not able to delete datasource when there's deleted actions #8627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
sharat87
added
the
skip-changelog
github-actions
bot
added
Bug
nayan-rafiq
approved these changes
Oct 21, 2021
|
/ok-to-test sha=8954017 |
1 similar comment
|
/ok-to-test sha=8954017 |
|
Test run result at: https://github.com/appsmithorg/appsmith/runs/3997692436 |
sharat87
changed the title
|
/ok-to-test sha=8ea9024 |
|
/ok-to-test sha=a0c767b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted actions are being counted when checking if a datasource has actions using it before deleting a datasource. This PR fixes this by excluding deleted actions from the count.
Test case is the same as #7880.
Fixes #4609.