Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: page number reset #8681

Merged
merged 3 commits into from
Oct 26, 2021
Merged

fix: page number reset #8681

merged 3 commits into from
Oct 26, 2021

Conversation

Tooluloope
Copy link
Contributor

@Tooluloope Tooluloope commented Oct 21, 2021 •
edited by github-actions bot

Description

Table widget - server-side pagination control: Page number is reset to 1 once the query has completed
Fixes #8621

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed 
// Code coverage diff between base branch:release and head branch: fix/serverside-pagination-and-page-number
Status File % Stmts % Branch % Funcs % Lines
🟢 app/client/src/widgets/TableWidget/widget/index.tsx 26.75 (0.18) 5.41 (-0.03) 28 (0) 26.65 (0.2)

@Tooluloope Tooluloope added App Viewers Pod This label assigns issues to the app viewers pod UI Building Pod labels Oct 21, 2021
@Tooluloope Tooluloope self-assigned this Oct 21, 2021
@github-actions github-actions bot added the Bug Something isn't working label Oct 21, 2021
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@Tooluloope Tooluloope requested review from riodeuno and somangshu and removed request for somangshu October 21, 2021 10:43
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

2 similar comments
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

riodeuno
riodeuno approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@riodeuno riodeuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riodeuno
Copy link
Contributor

@Tooluloope The build has failed so the checks cannot progress. The build has failed due to a jest test failing. Please check the details link in the Appsmith Client Build Workflow.

@Tooluloope
Copy link
Contributor Author

@Tooluloope The build has failed so the checks cannot progress. The build has failed due to a jest test failing. Please check the details link in the Appsmith Client Build Workflow.

Not sure why, just re-ran and it passed

@YogeshJayaseelan
Copy link
Contributor

@Tooluloope Tested this PR and it is working as expected now

@somangshu
Copy link
Contributor

@Tooluloope merge latest release, Run ok to test and make sure to merge this as soon as everything is done

@Tooluloope
Copy link
Contributor Author

/ok-to-test sha=8eba3b4

1 similar comment
@Tooluloope
Copy link
Contributor Author

/ok-to-test sha=8eba3b4

@Tooluloope Tooluloope enabled auto-merge (squash) October 26, 2021 07:36
@Tooluloope
Copy link
Contributor Author

https://dashboard.cypress.io/projects/eyxvp8/runs/11410/overview
All passed

@Tooluloope Tooluloope merged commit 3a40b76 into release Oct 26, 2021
@Tooluloope Tooluloope deleted the fix/serverside-pagination-and-page-number branch October 26, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riodeuno riodeuno riodeuno approved these changes

Assignees

@Tooluloope Tooluloope

Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Table widget - server side pagination control: Page number is reset to 1 once the query has completed
4 participants
@Tooluloope @riodeuno @YogeshJayaseelan @somangshu