Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button and ButtonTab component issue with onclick #109

Merged
merged 9 commits into from
Aug 16, 2022

Conversation

albinAppsmith
Copy link
Contributor

Description

This PR fixes the button and button tab component onclick event issue in main repo. While running the main repo in local, we have babel-plugin-styled-components plugin added to make styled component debugging easy. This plugin was trying to bind the context to the onclick events being passed to DS components.

The issue is resolved after using the onclick function by destructing from the props.

Fixes #15855

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Published alpha version and tested in main repo local

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2022

🦋 Changeset detected

Latest commit: 8fc60ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
design-system ✅ Ready (Inspect) Visit Preview Aug 16, 2022 at 6:42AM (UTC)

@tanvibhakta tanvibhakta merged commit 8eb7426 into release Aug 16, 2022
@tanvibhakta tanvibhakta deleted the fix/prop-destructring-btn-btn-tab branch August 16, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Design System Pod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Design System button and button tab are not clickable while passing onclick function
2 participants