Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Scrollbar component #728

Merged
merged 12 commits into from
Apr 25, 2024
Merged

feat: Added Scrollbar component #728

merged 12 commits into from
Apr 25, 2024

Conversation

albinAppsmith
Copy link
Contributor

@albinAppsmith albinAppsmith commented Apr 22, 2024

Description

This PR added new scrollbar component to the ADS 2.0 package.

Fixes appsmithorg/appsmith#32852

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: 89e4b4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 8:42pm

@albinAppsmith
Copy link
Contributor Author

/generate-alpha

Copy link
Contributor

Publish Result: @appsmithorg/design-system@0.0.0-alpha-20240422121512

@albinAppsmith
Copy link
Contributor Author

/generate-alpha

Copy link
Contributor

Publish Result: @appsmithorg/design-system@0.0.0-alpha-20240422184243

@albinAppsmith
Copy link
Contributor Author

/generate-alpha

Copy link
Contributor

Publish Result: @appsmithorg/design-system@0.0.0-alpha-20240422191556

@albinAppsmith
Copy link
Contributor Author

/generate-alpha

Copy link
Contributor

Publish Result: @appsmithorg/design-system@0.0.0-alpha-20240422193521

hetunandu
hetunandu previously approved these changes Apr 23, 2024
@albinAppsmith albinAppsmith merged commit c1a8818 into release Apr 25, 2024
8 checks passed
@albinAppsmith albinAppsmith deleted the scrollbar branch April 25, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] - Add scrollbar component to Design System
2 participants