Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding icon for git-repository #740

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

brayn003
Copy link
Contributor

@brayn003 brayn003 commented Jun 12, 2024

Description

Adds the icon for git-repository-line from remix-icons

Fixes appsmithorg/appsmith#34199

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 6:55am

Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: fb7a979

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brayn003 brayn003 changed the title chore: adding icon for git-repository feat: adding icon for git-repository Jun 12, 2024
@brayn003 brayn003 self-assigned this Jun 12, 2024
@github-actions github-actions bot added the Task A simple Todo label Jun 12, 2024
@brayn003
Copy link
Contributor Author

/generate-alpha

Copy link
Contributor

Publish Result: @appsmithorg/design-system@0.0.0-alpha-20240613065959

@albinAppsmith albinAppsmith merged commit bccd890 into release Jun 13, 2024
8 checks passed
@albinAppsmith albinAppsmith deleted the chore/add-icon-git-repo branch June 13, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add a new icon for git-repository
2 participants