You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Windows path names are likely to include the drive ID and a colon separator
Even Unix-style path and file names are allowed to include colons (try touch foo:bar and you'll see what I mean).
For now:
We mount volumes with -v : which won't work in case has a colon in it. We need to switch to the --mount syntax (or use the Go Docker APIs appropriately).
The issue is been fixed "for Windows" - assuming that the only extra colon we get can occur after the drive ID (i.e. C:/:).
The controller also has this issue when it defaults the WATCH_DIR from MOUNTS
@kylegc did a little more research on this and discussed with @chilanti . Even if we switch to the --mount syntax, we still have the issue of splitting the list of mounts with the ';' separator char.
The Ultimate solution is as follows:
Allow either docker -v or --mount syntax in APPSODY_MOUNTS var with a default separator of ';'. We can determine that --mount syntax is used if "src=" and "dst=" exist.
We provide an optional APPSODY_SEPARATOR var that allows the user to change the default separator of ';' to any string sequence they'd like.
Until this solution is implemented, it will be documented that ':' and ';' characters are not supported in the mount paths.
The text was updated successfully, but these errors were encountered:
Right now, `;` is hard-coded to be the mount separator
in the stack-mounts, which inhibits this character from
being used for path names.
Introduce an appsody env APPSODY_MOUNT_SEPARATOR that can
be used by stacks that want to use a different separator.
Partially fixes: appsody#31
neeraj-laad
changed the title
Adopt a volume-mounting Docker syntax that allows colons in path names
Support improved syntax for specifying file mounts
Oct 18, 2019
This issue has to do with the fact that:
Windows path names are likely to include the drive ID and a colon separator
Even Unix-style path and file names are allowed to include colons (try touch foo:bar and you'll see what I mean).
For now:
We mount volumes with -v : which won't work in case has a colon in it. We need to switch to the --mount syntax (or use the Go Docker APIs appropriately).
The issue is been fixed "for Windows" - assuming that the only extra colon we get can occur after the drive ID (i.e. C:/:).
The controller also has this issue when it defaults the WATCH_DIR from MOUNTS
@kylegc did a little more research on this and discussed with @chilanti . Even if we switch to the --mount syntax, we still have the issue of splitting the list of mounts with the ';' separator char.
The Ultimate solution is as follows:
Until this solution is implemented, it will be documented that ':' and ';' characters are not supported in the mount paths.
The text was updated successfully, but these errors were encountered: