Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Improve syntax for specifying file mounts #31

Open
kewegner opened this issue Jul 1, 2019 · 0 comments
Open

Improve syntax for specifying file mounts #31

kewegner opened this issue Jul 1, 2019 · 0 comments
Labels
enhancement New feature or request priority/low Low impact issue

Comments

@kewegner
Copy link
Collaborator

kewegner commented Jul 1, 2019

This issue has to do with the fact that:

  1. Windows path names are likely to include the drive ID and a colon separator

  2. Even Unix-style path and file names are allowed to include colons (try touch foo:bar and you'll see what I mean).

For now:

  1. We mount volumes with -v : which won't work in case has a colon in it. We need to switch to the --mount syntax (or use the Go Docker APIs appropriately).

  2. The issue is been fixed "for Windows" - assuming that the only extra colon we get can occur after the drive ID (i.e. C:/:).

  3. The controller also has this issue when it defaults the WATCH_DIR from MOUNTS

@kylegc did a little more research on this and discussed with @chilanti . Even if we switch to the --mount syntax, we still have the issue of splitting the list of mounts with the ';' separator char.

The Ultimate solution is as follows:

  1. Allow either docker -v or --mount syntax in APPSODY_MOUNTS var with a default separator of ';'. We can determine that --mount syntax is used if "src=" and "dst=" exist.
  2. We provide an optional APPSODY_SEPARATOR var that allows the user to change the default separator of ';' to any string sequence they'd like.

Until this solution is implemented, it will be documented that ':' and ';' characters are not supported in the mount paths.

@kewegner kewegner added the enhancement New feature or request label Jul 1, 2019
gireeshpunathil added a commit to gireeshpunathil/appsody that referenced this issue Sep 18, 2019
Right now, `;` is hard-coded to be the mount separator
in the stack-mounts, which inhibits this character from
being used for path names.

Introduce an appsody env APPSODY_MOUNT_SEPARATOR that can
be used by stacks that want to use a different separator.

Partially fixes: appsody#31
@neeraj-laad neeraj-laad changed the title Adopt a volume-mounting Docker syntax that allows colons in path names Support improved syntax for specifying file mounts Oct 18, 2019
@neeraj-laad neeraj-laad added the enhancement New feature or request label Oct 18, 2019
@neeraj-laad neeraj-laad changed the title Support improved syntax for specifying file mounts Improve syntax for specifying file mounts Oct 18, 2019
tnixa pushed a commit to tnixa/appsody that referenced this issue Nov 7, 2019
@neeraj-laad neeraj-laad added the priority/low Low impact issue label Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request priority/low Low impact issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants