migrate to dart 3, upgrade http, switch to 'lints' package from 'pedantic' #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i ignored constant_identifier_names for jwa file rather than modifying them
|
It would be great to have this migration merged. |
|
Ello @appsup-dart? |
|
Ello @rbellens ? |
kevmoo
reviewed
Jul 4, 2023
kevmoo
reviewed
Jul 4, 2023
|
Could anyone kindly share with me any updates on the status of the PR? I was just wondering why it hasn't been merged yet. Thank you. |
kevmoo
reviewed
Jul 17, 2023
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
|
I would also like to see this merged, so we can update open_id_client as well to http: 1.1.0. |
rbellens
approved these changes
Jul 24, 2023
|
Thanks all for the work. It has now been merged and released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates to dart 3 by setting the sdk constraint. This follows the update to http: 1.0.0. While doing those upgrades I migrated from deprecated pedantic to the lints package and solved all of the linting issues, including solidifying typing where appropriate.
instead of adjusting the const names I added an ignore
constant_identifier_namesto jwa.dart. I felt this was more appropriate over renaming.Modified SDK constraint:
sdk: '>=3.0.0 <4.0.0'fixes #52