Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore prelease part of go version #245

Merged
merged 2 commits into from Feb 9, 2022
Merged

Conversation

DrDaveD
Copy link
Contributor

@DrDaveD DrDaveD commented Feb 9, 2022

This cherry-picks apptainer/singularity#6378 with description

Fix mlocal/scripts/check-min-go-version to handle go versions like 1.18beta2 such as currently on Fedora 36.

Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
@DrDaveD DrDaveD added this to the 1.0.0 milestone Feb 9, 2022
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
@DrDaveD DrDaveD merged commit c9d336e into apptainer:main Feb 9, 2022
@DrDaveD DrDaveD deleted the singularity6378 branch February 9, 2022 23:47
DrDaveD pushed a commit that referenced this pull request Jun 30, 2022
* Port SingularityCE PR 245 to Apptainer

- Port SingularityCE PR 245 to Apptainer

- Add environment variable APPTAINER_REMOTE_ADD_INSECURE

  In order to allow "--insecure" to be missing in the command line,
  the APPTAINER_REMOTE_ADD_INSECURE environment variable allows to
  define this flag for all remote add operations with http remotes.
  If the remote URI starts with https, the --insecure and the
  APPTAINER_REMOTE_ADD_INSECURE are overruled.

Signed-off-by: Martin Köhler <koehlerm@mpi-magdeburg.mpg.de>

* gofumpt on service.go

Signed-off-by: Martin Köhler <koehlerm@mpi-magdeburg.mpg.de>

* Rename env var APPTAINER_REMOTE_ADD_INSECURE

The APPTAINER_REMOTE_ADD_INSECURE is now called
APPTAINER_ADD_INSECURE and uses the EnvKeys functionality.

Signed-off-by: Martin Köhler <koehlerm@mpi-magdeburg.mpg.de>

* Remove useless comment.

Signed-off-by: Martin Köhler <koehlerm@mpi-magdeburg.mpg.de>

* Change Info and Fatalf strings in remote.go

Signed-off-by: Martin Köhler <koehlerm@mpi-magdeburg.mpg.de>

Co-authored-by: Martin Köhler <koehlerm@mpi-magdeburg.mpg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants