updating --env flags to be a map[string]string, from sylabs 684 (1.0) #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the current flag using a splice type will truncate on commas. In order to better support commas in --env variables we should have support for types of map[string]string. This change will add this new option and fix the current --env bug described in slack that splits name=val1,val2 into just name=val1 and outputs a warning. I saw some custom parsing code in a different file that maybe was intended to handle this, but it never gets called because the envar is skipped. If it is not skipped the comma would already be truncated by the flag parser. Apologies for mistakes - have not looked at Singularity source code in years it seems! Signed-off-by: vsoch <vsoch@users.noreply.github.com> Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
DrDaveD
approved these changes
May 5, 2022
|
lol! Double contribution, win! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks #413 to the release-1.0 branch