Remove environment variables eval for --bind, --nv and --rocm for bui…

…ld command

CHANGELOG.md

@@ -14,6 +14,10 @@
     regression from Singularity 2.x. Note that you will now need to use
     `--force` in a build to override a label that already exists in the source
     Docker/OCI container.
+  - `--bind`, `--nv` and `--rocm` options for `build` command can't be set through
+    environment variables `SINGULARITY_BIND`, `SINGULARITY_NV`, `SINGULARITY_ROCM`
+    anymore due to side effects reported by users in https://github.com/hpcng/singularity/pull/6211,
+    they must be explicitely requested via command line.
 
 ## v3.8.2 - [2021-08-31]
 

cmd/internal/cli/build.go

@@ -215,7 +215,6 @@ var buildNvFlag = cmdline.Flag{
 	DefaultValue: false,
 	Name:         "nv",
 	Usage:        "inject host Nvidia libraries during build for post and test sections (not supported with remote build)",
-	EnvKeys:      []string{"NV"},
 }
 
 // --rocm
@@ -225,7 +224,6 @@ var buildRocmFlag = cmdline.Flag{
 	DefaultValue: false,
 	Name:         "rocm",
 	Usage:        "inject host Rocm libraries during build for post and test sections (not supported with remote build)",
-	EnvKeys:      []string{"ROCM"},
 }
 
 // -B|--bind
@@ -240,8 +238,6 @@ var buildBindFlag = cmdline.Flag{
 		"it is set equal to src. Mount options ('opts') may be specified as 'ro'" +
 		"(read-only) or 'rw' (read/write, which is the default)." +
 		"Multiple bind paths can be given by a comma separated list. (not supported with remote build)",
-	EnvKeys:    []string{"BIND", "BINDPATH"},
-	EnvHandler: cmdline.EnvAppendValue,
 }
 
 // --writable-tmpfs