Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify mksquashfs binary during ./configure #1662

Merged
merged 3 commits into from Jun 21, 2018
Merged

Specify mksquashfs binary during ./configure #1662

merged 3 commits into from Jun 21, 2018

Conversation

jmstover
Copy link
Contributor

Description of the Pull Request (PR):

Replacement for #1530 that should hopefully be much cleaner.

Checkoff for all PRs:

  • I have read the Guidelines for Contributing, and this PR conforms to the stated requirements.
  • [] I have added changes to the CHANGELOG and and documentation updates to the singularityware documentation base.
  • [] I have tested this PR locally with a make test
  • This PR is NOT against the project's master branch
  • [] I have added myself as a contributor to the contributors's file
  • This PR is ready for review and/or merge

Attn: @singularityware-admin

@jmstover
Specify mksquashfs location
a931ec6 
Replacement for PR #1530. This PR _should_ be much cleaner.
@jmstover jmstover mentioned this pull request Jun 15, 2018
Closed
4 tasks
@GodloveD GodloveD added this to the 2.6 Release milestone Jun 15, 2018
GodloveD
GodloveD approved these changes Jun 15, 2018
View reviewed changes
Copy link
Collaborator

@GodloveD GodloveD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dtrudg
dtrudg approved these changes Jun 16, 2018
View reviewed changes
Copy link
Contributor

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... tested and using a mksquashfs in custom location okay!

@GodloveD GodloveD merged commit da773b7 into apptainer:development-2.x Jun 21, 2018
@GodloveD
Copy link
Collaborator

Thanks @jmstover and @dctrud.

@omenos omenos mentioned this pull request Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtrudg dtrudg dtrudg approved these changes

@GodloveD GodloveD GodloveD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmstover @GodloveD @dtrudg