Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address 'Ctty not valid in child' in e2e-test #5509

Merged
merged 1 commit into from Aug 18, 2020
Merged

fix: address 'Ctty not valid in child' in e2e-test #5509

merged 1 commit into from Aug 18, 2020

Conversation

tri-adam
Copy link
Contributor

Explicitly pass console TTY descriptor via Extrafiles, and set Ctty to child file descriptor, as per golang/go#29458.

Fixes #5508

@tri-adam tri-adam added Bug e2e End-to-end framework ci:e2e labels Aug 18, 2020
@tri-adam tri-adam marked this pull request as ready for review August 18, 2020 19:38
@tri-adam tri-adam requested a review from dtrudg August 18, 2020 19:38
dtrudg
dtrudg approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this fixes things on go 1.15 and still works <1.15 👍

@dtrudg dtrudg added this to the 3.6.2 milestone Aug 18, 2020
@tri-adam tri-adam merged commit 4ff114d into apptainer:master Aug 18, 2020
@tri-adam tri-adam deleted the ctty-fix branch August 18, 2020 20:27
@dtrudg dtrudg mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtrudg dtrudg dtrudg approved these changes

Assignees
No one assigned
Labels
Bug ci:e2e e2e End-to-end framework
Projects
None yet
Milestone
3.6.2
Development

Successfully merging this pull request may close these issues.

E2E Tests Fail with "Ctty not valid in child"
2 participants
@tri-adam @dtrudg