Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showing the rating dialog from a modal #32

Closed
kgn opened this issue Feb 16, 2013 · 4 comments
Closed

Showing the rating dialog from a modal #32

kgn opened this issue Feb 16, 2013 · 4 comments
Assignees
@wooster
Milestone
v0.4.9

Comments

@kgn
Copy link
Contributor

kgn commented Feb 16, 2013 

Warning: Attempt to present <SKStoreProductViewController: 0x21171e10> on <UINavigationController: 0x1fdcb470> whose view is not in the window hierarchy!

This is fixed in this commit, though it is only fixed for iOS 5. If iOS 4 is still supported modalViewController could be used but I don't have iOS 4 to test against.

kgn@aa6e1d2
@kgn
Copy link
Contributor Author

kgn commented Feb 16, 2013

Sorry that commit broke the code for non-modal view controllers. This commit fixes it and adds code for iOS 4, though it's untested: kgn@d5e1d23

@ghost ghost assigned wooster Feb 17, 2013
@wooster
Copy link
Contributor

wooster commented Feb 17, 2013

Great catch. Will go in next release.

@wooster
Copy link
Contributor

wooster commented Apr 7, 2013

Tested fix on iOS 4.3 in a custom app, also iOS 5 and 6. Seems to work great. Will definitely be in next release.

@wooster
Copy link
Contributor

wooster commented Jun 7, 2013

This should be fixed in the new 0.4.9 release. Thanks!

@wooster wooster closed this as completed Jun 7, 2013
@matt-alltrails matt-alltrails mentioned this issue Aug 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wooster wooster

Labels
None yet
Projects
None yet
Milestone
v0.4.9
Development

No branches or pull requests
2 participants
@wooster @kgn