Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New podspec to use source instead of Lib #47

Merged
merged 3 commits into from
Sep 27, 2013
Merged

New podspec to use source instead of Lib #47

merged 3 commits into from
Sep 27, 2013

Conversation

josmo
Copy link

@josmo josmo commented Sep 4, 2013

This will make it easier to use the latest code updates and tags without having to release binaries. Also, it'll make it simpler for people to use internal podspec repos and custom implementations of ApptentiveConnect.

Note: bug CocoaPods/CocoaPods#1309 from cocaopods which should get pulled into .24.1 release of cocoapods will allow resource_bundles for targets other then Debug, and Release. In .24 it's completely broken and in .23 it will only support Debug and Release targets.

Hill-Grannec added 3 commits September 4, 2013 11:52
…e custom versions of ApptentiveConnect and still use Cocoapods for dependency management as well and contributing back and being able to pull from the master without needing to completely changing the build environment.
@wooster
Copy link
Contributor

wooster commented Sep 16, 2013

Thanks!

There are a few things that'll need to be changed when this gets pulled in.

The logging is a bit too aggressive in the xcconfig, so we'll want to change it to match the existing project based o n config parameters. eg, "GCC_PREPROCESSOR_DEFINITIONS[config=Debug] = ", etc.

We have some new localizations that should be brought into the resource bundle.

I'll try to get this into the next release.

@josmo
Copy link
Author

josmo commented Sep 16, 2013

Thanks Andrew and no worries, whatever changes makes sense.

Let me know if you need anything and it's definitely best to wait till the next version of cocoapods to push this out anyways since the current version is broke for resource_bundles.

@ghost ghost assigned wooster Sep 25, 2013
wooster added a commit that referenced this pull request Sep 27, 2013
New podspec to use source instead of Lib
@wooster wooster merged commit 0cce42d into apptentive:master Sep 27, 2013
pkamb added a commit that referenced this pull request Sep 3, 2015
IOSOSX-158 and IOSOSX-160: Status messages for HTTP Errors and Network Errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants